Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use make instead of bazel #129

Closed
wants to merge 1 commit into from
Closed

use make instead of bazel #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions build_forklift_bazel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,13 @@ bazel run push-populator-controller
bazel run push-forklift-api
bazel run push-forklift-controller
bazel run push-forklift-validation
bazel run push-forklift-operator

# forklift-operator is not built with bazel
REGISTRY_ORG=ci make push-operator-image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we set REGISTRY_ORG to ci here? do we set it to ci elsewhere?


ACTION_ENV="--action_env CONTROLLER_IMAGE=${REGISTRY}/forklift-controller:${REGISTRY_TAG} \
--action_env VALIDATION_IMAGE=${REGISTRY}/forklift-validation:${REGISTRY_TAG} \
--action_env OPERATOR_IMAGE=${REGISTRY}/forklift-operator:${REGISTRY_TAG} \
--action_env OPERATOR_IMAGE=${REGISTRY}/ci/forklift-operator:${REGISTRY_TAG} \
--action_env API_IMAGE=${REGISTRY}/forklift-api:${REGISTRY_TAG}"

# if provider is ovirt or openstack, builder populator controller
Expand Down Expand Up @@ -89,7 +91,7 @@ fi
bazel run push-forklift-operator-bundle \
--action_env CONTROLLER_IMAGE=${REGISTRY}/forklift-controller:${REGISTRY_TAG} \
--action_env VALIDATION_IMAGE=${REGISTRY}/forklift-validation:${REGISTRY_TAG} \
--action_env OPERATOR_IMAGE=${REGISTRY}/forklift-operator:${REGISTRY_TAG} \
--action_env OPERATOR_IMAGE=${REGISTRY}/ci/forklift-operator:${REGISTRY_TAG} \
--action_env API_IMAGE=${REGISTRY}/forklift-api:${REGISTRY_TAG} \
${ACTION_ENV}

Expand Down
Loading