-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to using Docsy as an npm module #557
Comments
Sounds good, let Contribex know when you want to get started. |
I think we should do this before #531; I just saw that the change doesn't actually preview OK @SayakMukhopadhyay. Adopting the approach planned for k/website should fix this issue and make upgrades easier. |
@sftim I saw your comment on the kubernetes/website#48726 PR. Are you considering using Hugo modules for managing the docsy themes? |
The problem is that the current version of Docsy that is deployed didn't support themeing in either NPM or Go modules way. Git Submodules was the only option. So, this change cannot happen without migrating to at least 0.5. |
Let's move to Docsy 0.5.1 (same approach as k/website). Then, continue onwards. |
Still my recommendation. 0.6 is fine; moving via 0.5.1 will make things overall easier for approvers. |
We would like to move from using Docsy as a git submodule to an NPM dependency. This is the proposed approach for the docs website (kubernetes/website#48812) and we would like to do it here too, ideally after #531 is merged.
The text was updated successfully, but these errors were encountered: