bug: node group min size reached (current: 2, min: 3)

[meysam81]

Hey guys, I noticed this if conditional is not correct and I have placed the log to the title of this issue.

The gist of is that the conditional should be reversed, meaning, the size must be greater equal than minSize:

size >= minSize

autoscaler/cluster-autoscaler/processors/nodes/pre_filtering_processor.go

Line 66 in 61eae9e

if size <= minSize {

[adrianmoisey]

/area cluster-autoscaler

[meysam81]

this might have most likely been a misunderstanding from my part.

I see that the function name is GetScaleDownCandidates, as in, the nodes that will be destroyed.

https://github.com/kubernetes/autoscaler/blob/61eae9e5022f2f53f1c80a7006ec875bae3f7581/cluster-autoscaler/processors/nodes/pre_filtering_processor.go#L44C46-L44C68

My problem is remains though, the min=3 is never met.
I have a feeling this has to do with Hetzner resource creation limit, thought that can be ruled out knowing that a request to increase the limit has been submitted earlier to this and it has been approved.

It remains a mystery to me for now!