Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(helm): integrate the helm chart #7467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(helm): integrate the helm chart #7467

wants to merge 1 commit into from

Conversation

pierluigilenoci
Copy link
Contributor

@pierluigilenoci pierluigilenoci commented Nov 6, 2024 •
edited
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Added node-deletion-delay-timeout and node-deletion-batcher-interval to FAQ.md and as chart example.

Which issue(s) this PR fixes:

Fixes #7470
Fixes #2031 (the lack of update on the FAQ of this PR)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 6, 2024
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/helm-charts needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @pierluigilenoci. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2024
@pierluigilenoci pierluigilenoci force-pushed the nodeDeletionDelayTimeout branch from 24a9612 to 82366b9 Compare November 6, 2024 10:37
@pierluigilenoci
Copy link
Contributor Author

@mwielgus @MaciekPytel @gjtempleton, could you please take a look?

jackfrancis
jackfrancis approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2024
@pierluigilenoci
Copy link
Contributor Author

@jackfrancis, could you please also approve?

@pierluigilenoci
Copy link
Contributor Author

/assign @gjtempleton

@pierluigilenoci
Copy link
Contributor Author

/assign @aleksandra-malinowska

@Shubham82
Copy link
Contributor

PR #7470 has already been opened to add all the CA flags under the FAQ.md parameter table.

@Shubham82
Copy link
Contributor

@pierluigilenoci, you can keep the changes for the charts directory, other than that you can drop them as they are covered in the other PR.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jackfrancis, pierluigilenoci
Once this PR has been reviewed and has the lgtm label, please ask for approval from gjtempleton. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierluigilenoci pierluigilenoci force-pushed the nodeDeletionDelayTimeout branch from 4721e28 to d4820d7 Compare November 7, 2024 14:50
@pierluigilenoci
Copy link
Contributor Author

@Shubham82 done.
@jackfrancis, could you please retake a look?

@pierluigilenoci pierluigilenoci changed the title chore(docs): integrate the FAQ and the helm chart chore(docs): integrate the helm chart Nov 7, 2024
@pierluigilenoci pierluigilenoci changed the title chore(docs): integrate the helm chart chore(helm): integrate the helm chart Nov 7, 2024
@jackfrancis
Copy link
Contributor

@Shubham82 I'm a little confused about your earlier comment about another PR. #7470 is the issue that this PR addresses.

Is there more than one solution for this in flight?

@Shubham82
Copy link
Contributor

Shubham82 commented Nov 8, 2024 •
edited
Loading

@jackfrancis, issue #7470 is opened to add the missing flags in the parameter table under FAQ.md but there is already PR #7014 opened for it in which we add new hack script that Auto-generate the supported flags table in FAQ,md.

As mentioned in the issue description, this PR focuses on two problems:

  1. adding the node-deletion-delay-timeout or node-deletion-batcher-interval flag.
  2. update the values.yaml for charts for these flags

As 1st is already covered in #7014, so it will be good if this PR only covers 2nd issue i.e. updating values.yaml file for charts.

@pierluigilenoci
Copy link
Contributor Author

@jackfrancis, can you please follow up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x13n x13n Awaiting requested review from x13n

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@jackfrancis jackfrancis

@aleksandra-malinowska aleksandra-malinowska

@gjtempleton gjtempleton

Labels
area/cluster-autoscaler area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameters missing from the FAQ.
6 participants
@pierluigilenoci @k8s-ci-robot @Shubham82 @jackfrancis @aleksandra-malinowska @gjtempleton