Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 20.0.0 is not registering model in processAot task #3134

Open
cache-sk opened this issue Feb 29, 2024 · 8 comments
Open

Version 20.0.0 is not registering model in processAot task #3134

cache-sk opened this issue Feb 29, 2024 · 8 comments

Comments

@cache-sk
Copy link

Describe the bug

Project build with gradle, using org.springframework.boot and org.graalvm.buildtools.native.

As dependency we have, among others:

  • io.kubernetes:client-java
  • io.kubernetes:client-java-extended
  • io.kubernetes:client-java-spring-aot-integration

There are no problems with java build and java runtime, problem is native build with graalvm plugin.

With client versions 19.0.0 and 20.0.0-legacy, during processAot task, all model from io.kubernetes.client.openapi.models package is registered and processed to reflect-config.json.

But not with version 20.0.0, which in native build runtime ends up with root cause (for example):

java.lang.IllegalArgumentException: Type io.kubernetes.client.openapi.models.VersionInfo is instantiated reflectively but was never registered. Register the type by adding "unsafeAllocated" for the type in reflect-config.json.

I assume, that something was forgotten when implementing breaking changes..

I have already rewritten all the calls to the changes brought by version 20.0.0, I would not like to revert everything to the legacy version,

Client Version
20.0.0

Kubernetes Version
1.28.7

Java Version
With client 19.0.0 was used Java 17, spring boot 3.1.5 and graalvm build tools 0.9.27.
With client 20.0.0 and 20.0.0-legacy was used Java 21, spring boot 3.2.2 and graalvm build tools 0.10.0

Expected behavior
Model should be registered with version 20.0.0 in same way as with 19.0.0 or 20.0.0-legacy

@HyoKImAbsolut
Copy link

same problem

@GregoireW
Copy link

The issue is linked to either a missing annotation on generated model class or the way class are added in the registration class.

Today it is:

Set<Class<?>> apiModels = reflections.getTypesAnnotatedWith(ApiModel.class);

so scan of ApiModel but it is not existing anymore in 20 (non legacy). ex: deployment look like:

*/
@jakarta.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2024-02-02T17:56:12.287571Z[Etc/UTC]")
public class V1Deployment implements io.kubernetes.client.common.KubernetesObject {

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 23, 2024
@cache-sk
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 25, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 23, 2024
@cache-sk
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 23, 2024
@cache-sk
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants