Updated scripts and workflows to test kruize docker image from the manifest yaml #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandrams
force-pushed
the
manifest_build
branch
from
603a0e8 to
85adcc7
Compare
chandrams
force-pushed
the
manifest_build
branch
2 times, most recently
from
8d0c82f to
f48507b
Compare
dinogun
reviewed
Aug 31, 2023
tests/test_autotune.sh
Outdated
Comment on lines
216
to
220
| #if [ -z "${AUTOTUNE_DOCKER_IMAGE}" ]; then | ||
| # if [ ${testsuite} != "remote_monitoring_tests" ]; then | ||
| # AUTOTUNE_DOCKER_IMAGE="${AUTOTUNE_IMAGE}" | ||
| # fi | ||
| #fi |
There was a problem hiding this comment.
Please remove commented out code
rbadagandi1
modified the milestones:
Kruize 0.0.18_rm Release,
Kruize 0.0.19_rm Release
rbadagandi1
modified the milestones:
Kruize 0.0.19_rm Release,
Kruize 0.0.20_rm Release
|
run functional tests |
|
@chandrams Please fix the conflicts |
chandrams
force-pushed
the
manifest_build
branch
2 times, most recently
from
466f2fc to
2736d80
Compare
|
@chandrams Please fix the conflicts |
… image in the manifest file for remote monitoring Signed-off-by: Chandrakala Subramanyam <[email protected]>
Signed-off-by: Chandrakala Subramanyam <[email protected]>
…ize pod name Signed-off-by: Chandrakala Subramanyam <[email protected]>
Signed-off-by: Chandrakala Subramanyam <[email protected]>
Signed-off-by: Chandrakala Subramanyam <[email protected]>
chandrams
force-pushed
the
manifest_build
branch
from
2736d80 to
24e85d4
Compare
|
@dinogun I have resolved the conflicts, please review. |
|
So is the test_crc_manifest_build job expected to fail? |
|
From the Logs I see it is still using 0.0.19.4_rm build, let me push a change and trigger the build again |
Signed-off-by: Chandrakala Subramanyam <[email protected]>
|
Now it picked the build from the manifest which is 0.0.20_rm but failed as the build is not available on docker.hub |
dinogun
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated scripts and workflows to test kruize docker image from the manifest yaml