Functional test suit amendment to address RM and LM #1424
Conversation
| @@ -122,7 +124,7 @@ def main(argv): | |||
| experiment_name = None | |||
| latest = "false" | |||
| interval_end_time = None | |||
| response = list_recommendations(experiment_name, latest, interval_end_time) | |||
| response = list_recommendations(experiment_name, latest, interval_end_time, rm=True) | |||
There was a problem hiding this comment.
@msvinaykumar - This change should be made in the remote monitoring fault tolerant test.
There was a problem hiding this comment.
Where is this change done? I still see rm=True in local monitoring fault tolerant test.
There was a problem hiding this comment.
This change is necessary for Fault Tolerance. Are you suggesting removing it from this PR and including it in the Fault Tolerance PR instead? Or is this change not required at all?
There was a problem hiding this comment.
We have fault tolerant test in both local monitoring and remote monitoring. This change I think is applicable only for remote monitoring fault tolerant test.
There was a problem hiding this comment.
Got it, thank you. I removed this change, but the file was still checked in due to a formatting issue.
msvinaykumar
force-pushed
the
cft-7-TestForConncurrentLMRM
branch
from
af0b117 to
595c30a
Compare
|
@msvinaykumar - PR check has failed, can you take a look. |
done |
|
@msvinaykumar Please rebase this PR |
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
msvinaykumar
force-pushed
the
cft-7-TestForConncurrentLMRM
branch
from
487b633 to
65602f7
Compare
done |
Signed-off-by: msvinaykumar <[email protected]>
Description
Functional test suite amendment to address RM and LM .
List_recommendations is called using flag rm=true from remote monitoring test cases.
Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here