Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listExperiments fix for concurrent rm and lm #1421

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

msvinaykumar
Copy link
Contributor

@msvinaykumar msvinaykumar commented Dec 15, 2024

Description

Introduced the rm=true flag for the ROS Remote Monitoring use case. When rm=true is passed in the listExperiments API, the API refers to remote monitoring tables. By default, the flag is set to false, which points to local monitoring tables. This feature is not critical for the ROS Remote Monitoring use case, as they do not utilize the listExperiments API. Therefore, a documentation update is not required.

Fixes # (issue)

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on:

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

Include any additional information such as links, test results, screenshots here

@msvinaykumar msvinaykumar added the API Requires API Changes label Dec 15, 2024
@msvinaykumar msvinaykumar added this to the Kruize 0.3 Release milestone Dec 15, 2024
@msvinaykumar msvinaykumar self-assigned this Dec 15, 2024
@chandrams
Copy link
Contributor

@msvinaykumar - Fault tolerant test in remote monitoring invokes listExperiments, can you please check if this runs fine or needs any changes.

@msvinaykumar
Copy link
Contributor Author

@msvinaykumar - Fault tolerant test in remote monitoring invokes listExperiments, can you please check if this runs fine or needs any changes.

thank you will create seperate PR.

@chandrams chandrams requested a review from khansaad December 17, 2024 08:40
Copy link
Contributor

@chandrams chandrams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandrams chandrams merged commit 5473b36 into kruize:mvp_demo Dec 17, 2024
1 of 2 checks passed
@dinogun
Copy link
Contributor

dinogun commented Dec 17, 2024

@msvinaykumar Please rebase this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Requires API Changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants