list Recommendations to support both rm and lm #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
@msvinaykumar Please fix the conflict |
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
msvinaykumar
force-pushed
the
cft-5-RecommendationTable
branch
from
d751dcb to
ad2936c
Compare
done |
khansaad
approved these changes
Dec 17, 2024
| @@ -121,7 +122,7 @@ private static Map<String, String> parseLabelString(String labelString) { | |||
| public void run() { | |||
| String statusValue = "failure"; | |||
| MetricsConfig.activeJobs.incrementAndGet(); | |||
| Timer.Sample timerRunJob = Timer.start(MetricsConfig.meterRegistry()); | |||
| io.micrometer.core.instrument.Timer.Sample timerRunJob = Timer.start(MetricsConfig.meterRegistry()); | |||
There was a problem hiding this comment.
|
@msvinaykumar Can you please move all of the RM only code (including the DB files) to the bottom of each file and add a comment to it that this "section" is RM only. That way when we deprecate the code, it is easy to be removed at a later point. This can be done in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced the rm=true flag for the ROS Remote Monitoring use case. When rm=true is passed in the listRecommendations API, the API refers to remote monitoring tables. By default, the flag is set to false, which points to local monitoring tables. This feature is not critical for the ROS Remote Monitoring use case, as they do not utilize the listRecommendations API. Therefore, a documentation update is not required.
Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here