5. Adding Recommendation Updater Service [KRUIZE-VPA Integration] #1416
Conversation
shekhar316
changed the title
shekhar316
changed the title
shekhar316
force-pushed
the
vpa-service
branch
from
1e8afc8 to
5fb601c
Compare
shekhar316
force-pushed
the
vpa-service
branch
3 times, most recently
from
5214645 to
87eb9f2
Compare
Signed-off-by: Shekhar Saxena <[email protected]>
Signed-off-by: Shekhar Saxena <[email protected]>
Signed-off-by: Shekhar Saxena <[email protected]>
shekhar316
force-pushed
the
vpa-service
branch
from
87eb9f2 to
69ad30e
Compare
Signed-off-by: Shekhar Saxena <[email protected]>
|
@shekhar316 Can you please add documentation for the "auto" and "recreate" modes in the design folder. Currently we have an docs for Monitoring and Experiment modes and we can create a common doc in UpdateModes.md |
| //todo load only experimentStatus=inprogress , playback may not require completed experiments | ||
| List<KruizeLMExperimentEntry> entries = null; | ||
| String statusValue = "failure"; | ||
| Timer.Sample timerLoadAllExp = Timer.start(MetricsConfig.meterRegistry()); |
There was a problem hiding this comment.
Is this a new timer that is being added? Can you please update this file with the details on what this means
There was a problem hiding this comment.
This isn't a new timer. It's already present timerLoadAllExp. Because the table name has changed in Local Monitoring mode to KruizeLMExperiments. The loadAllExperiments function was not returning anything due to this change. This new function is created to load experiments from the local monitoring table KruizeLMExperiments, but it is similar to loadAllExperiments which is used in remote monitoring case.
Sure @dinogun , I will raise a PR for updated documentation by combining monitoring and experiment modes docs with |
Description
This PR introduces a service for updating deployments for
autoorrecreatemode experiments.Type of change
How has this been tested?
Tested on both the ResourceHub cluster.
Test Configuration
Kubernetes clusters tested on: ResourceHub (OpenShift)
Checklist 🎯