Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4-Migration add "isROSEnabled": "true" for RM #1414

Merged
merged 8 commits into from
Dec 10, 2024

Conversation

msvinaykumar
Copy link
Contributor

Description

For test cases where the target cluster is remote and ROS is enabled, we need to include "isROSEnabled": "true".

Fixes # (issue)

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on:

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

Include any additional information such as links, test results, screenshots here

@msvinaykumar
Copy link
Contributor Author

test_crc_manifest_build expected to fail as it does not build new image

@msvinaykumar
Copy link
Contributor Author

remove local falg from configuration and defaults to True

@msvinaykumar
Copy link
Contributor Author

will Resolve confilts

@msvinaykumar
Copy link
Contributor Author

remove local falg from configuration and defaults to True

done

1 similar comment
@msvinaykumar
Copy link
Contributor Author

remove local falg from configuration and defaults to True

done

Copy link
Contributor

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun dinogun merged commit 292a20d into kruize:mvp_demo Dec 10, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants