-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4-Migration add "isROSEnabled": "true" for RM #1414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msvinaykumar
force-pushed
the
cft-4-testsuit
branch
from
December 7, 2024 02:54
bd345d3
to
ab45c34
Compare
|
remove local falg from configuration and defaults to True |
msvinaykumar
force-pushed
the
cft-4-testsuit
branch
from
December 9, 2024 10:10
0d017c3
to
a0b3bdc
Compare
will Resolve confilts |
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
msvinaykumar
force-pushed
the
cft-4-testsuit
branch
from
December 10, 2024 05:07
a0b3bdc
to
749071f
Compare
done |
1 similar comment
done |
dinogun
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For test cases where the target cluster is remote and ROS is enabled, we need to include "isROSEnabled": "true".
Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here