Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with the Bulk API Scale Tests #1400

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

khansaad
Copy link
Contributor

@khansaad khansaad commented Nov 29, 2024

Description

This PR fixes issues with the Bulk API scale tests

Fixes # (#1399 )

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on: Openshift

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

Include any additional information such as links, test results, screenshots here

@khansaad khansaad added the bug Something isn't working label Nov 29, 2024
@khansaad khansaad added this to the Kruize 0.3 Release milestone Nov 29, 2024
@khansaad khansaad self-assigned this Nov 29, 2024
@khansaad khansaad marked this pull request as ready for review December 4, 2024 05:48
@khansaad khansaad linked an issue Dec 4, 2024 that may be closed by this pull request
@khansaad khansaad requested a review from chandrams December 4, 2024 05:49
@chandrams
Copy link
Contributor

@khansaad - Have you tested it with the scale test and thanos setup?

@khansaad
Copy link
Contributor Author

khansaad commented Dec 4, 2024

@khansaad - Have you tested it with the scale test and thanos setup?

With prometheus in the resource hub cluster, scale test worked fine. But with thanos in the kruize-scalelab cluster, I'm getting 503 after sometime.

However, in both cases the ConstraintViolation exception is not seen now.

@khansaad
Copy link
Contributor Author

khansaad commented Dec 4, 2024

@khansaad
Copy link
Contributor Author

khansaad commented Dec 4, 2024

@chandrams
Copy link
Contributor

@khansaad - I think 503 is with 1k containers, can you share the build you used.

@khansaad
Copy link
Contributor Author

khansaad commented Dec 6, 2024

@khansaad - I think 503 is with 1k containers, can you share the build you used.

quay.io/khansaad/autotune_operator:time-range-fix

@chandrams
Copy link
Contributor

@khansaad - I still see the issue with the above image

./bulk_scale_test.sh -i quay.io/khansaad/autotune_operator:time-range-fix -w 5 -r /tmp/res

{
    "status": "COMPLETED",
    "total_experiments": 1,
    "processed_experiments": 1,
    "notifications": null,
    "experiments": {
        "thanos|default|msc-0|tfb-qrh-sample-0(deployment)|tfb-0": {
            "notification": {
                "type": "ERROR",
                "message": "{\"documentationLink\":\"\",\"message\":\"Converting `org.hibernate.exception.ConstraintViolationException` to JPA `PersistenceException` : could not execute statement\",\"httpcode\":400,\"status\":\"ERROR\"}",
                "code": 400
            },
            "recommendations": {
                "status": "UNPROCESSED",
                "notifications": null
            }
        }
    },
    "webhook": null,
    "job_id": "84e9236d-eab8-4f4b-916e-92894404e156",
    "job_start_time": "2024-12-06T11:25:06.836Z",
    "job_end_time": "2024-12-06T11:25:07.182Z"
}

@chandrams
Copy link
Contributor

I have re-tested this again, but haven't seen this issue. Could be intermittent though, for now we can merge this and will raise another issue if seen again

Copy link
Contributor

@chandrams chandrams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun dinogun merged commit 5c30a41 into kruize:mvp_demo Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Parallel requests to Bulk API failed with ConstraintViolationException
3 participants