-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhook implementation #1373
webhook implementation #1373
Conversation
@msvinaykumar I think the implementation is unnecessarily adding complexity. What we need is to embed the webhook as part of the Bulk API itself.
Also what gets posted on the Webhook is the BulkAPI response as-is. |
@msvinaykumar Please fix the conflicts |
6fb2e85
to
d7aec44
Compare
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
d7aec44
to
efffed2
Compare
Implemented |
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The
webhook
parameter allows the system to notify an external service or consumer about the completion status ofan experiment-processing job. When a job is completed, this webhook will be triggered to send an HTTP request to a
predefined URL, configured either via an environment variable (
webhookURL
) or within akruize
configurationfile.
This notification mechanism is essential for systems that require real-time updates about the job's processing
status, enabling consumers to take immediate follow-up actions. For example, an external analytics dashboard, a
monitoring service, or a message queue like Kafka can listen for these webhook calls to further process or log the
job completion data.
Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here