Add Time Range Filter for Bulk API #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saad Khan <[email protected]>
Signed-off-by: Saad Khan <[email protected]>
| @@ -144,6 +144,10 @@ public void addDataSourcesFromConfigFile(String configFileName) { | |||
| DataSourceInfo dataSourceInfo = new ExperimentDBService().loadDataSourceFromDBByName(name); | |||
| if (null != dataSourceInfo) { | |||
| LOGGER.error("Datasource: {} already exists!", name); | |||
| // add the auth details to local object | |||
There was a problem hiding this comment.
Is this change related to PR ?
There was a problem hiding this comment.
No, this was pulled from #1358 . It needs to be merged first.
There was a problem hiding this comment.
@msvinaykumar To avoid confusion, I have removed this change from this PR now. This can be merged now, no dependency on #1358 now.
|
@khansaad Please resolve the conflicts |
Signed-off-by: Saad Khan <[email protected]>
Signed-off-by: Saad Khan <[email protected]>
Done |
|
@khansaad This needs an example to be added in the Documentation |
dinogun
reviewed
Nov 15, 2024
dinogun
reviewed
Nov 15, 2024
dinogun
reviewed
Nov 15, 2024
Signed-off-by: Saad Khan <[email protected]>
dinogun
reviewed
Nov 15, 2024
Signed-off-by: Saad Khan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the feature to get the bulk API result within a specified duration i.e. start and end time.
Note: This is on top of 1358 which needs to be merged first.
Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here