Fix missing datasource issue on pod restart

[khansaad]

Description

This PR fixes the issue with datasource which is causing a missing or invalid datasource exception. Details for the same are mentioned in Issue 1356

Fixes 1356

Type of change

• Bug fix
• New feature
• Docs update
• Breaking change (What changes might users need to make in their application due to this PR?)
• Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

• New Test X
• Functional testsuite

Test Configuration

• Kubernetes clusters tested on: Openshift

Checklist 🎯

• Followed coding guidelines
• Comments added
• Dependent changes merged
• Documentation updated
• Tests added or updated

Additional information

Include any additional information such as links, test results, screenshots here

[chandrams]

@khansaad - I still see the issue, Is this working for you?

[msvinaykumar]

Do we need to check if getAuthenticationConfig() will retun null
if so then do setAuthenticationConfig() ?

[khansaad]

We don't need that because in case of missing auth, getAuthenticationDetails() will return the default auth i.e. noAuth

Reference:

autotune/src/main/java/com/autotune/common/datasource/DataSourceCollection.java

Line 188 in a2c4e34

authConfig = AuthenticationConfig.noAuth();

[khansaad]

@khansaad - I still see the issue, Is this working for you?

@chandrams Looks like you're not passing the datasource name in the bulk API demo. In that case, the code takes the default datasource name as prometheus-1 . So, when you're running it with thanos , it's giving you the invalid datasource error which is expected.

I have updated the error message now to indicate the datasource name passed.

[chandrams]

@khansaad - I still see the issue, Is this working for you?

@chandrams Looks like you're not passing the datasource name in the bulk API demo. In that case, the code takes the default datasource name as prometheus-1 . So, when you're running it with thanos , it's giving you the invalid datasource error which is expected.

I have updated the error message now to indicate the datasource name passed.

I have tested with the below in the manifest file:

 "datasource": [
        {
          "name": "thanos",
          "provider": "prometheus",
          "serviceName": "",
          "namespace": "",
          "url": "http://thanos-query-frontend.thanos-bench.svc.cluster.local:9090/",
          "authentication": {
            "type": "bearer",
            "credentials": {
              "tokenFilePath": "/var/run/secrets/kubernetes.io/serviceaccount/token"
            }
          }
        }
      ]

[chandrams]

I have included datasource in the bulk config, with this I don't see the invalid datasource issue.

[msvinaykumar]

LGTM

[msvinaykumar]

@khansaad if required please feel free add negative testcases

[dinogun]

LGTM