You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd suggest switching to names that are more in line which what are the standard, or what angular uses in a few cases.
For example:
I would get rid of the $ prefix for your variables. The $ is supposed to be reserved only for angular core to make it easy for angular to parse out what are internal properties and methods. Using a $ prefix has the potential to cause bugs. Consider using an underscore prefix '_'
I would switch the method '$find' to something that better identifies the http method that will be used... get (or query to take angular's lead)
Rather than using .success and .error, I would switch to a promise based approach using angular $q. Namely, .then for success, and .catch for error. These have the unique ability to change the response and pass it to the next promise.
I had submitted a pr when this project was in its infancy and it's great to see you continuing it. I recently just started an open source project of my own which automatically generates angular injectables from 3rd party libraries so they don't end up as global variables. let me know what you think. http://github.com/btesser/angular-global-injector
The text was updated successfully, but these errors were encountered:
Hey,
I'd suggest switching to names that are more in line which what are the standard, or what angular uses in a few cases.
For example:
I had submitted a pr when this project was in its infancy and it's great to see you continuing it. I recently just started an open source project of my own which automatically generates angular injectables from 3rd party libraries so they don't end up as global variables. let me know what you think. http://github.com/btesser/angular-global-injector
The text was updated successfully, but these errors were encountered: