Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal typed password characters to users during login #6305

Open
aetherfaerber opened this issue Nov 15, 2024 · 5 comments
Open

Reveal typed password characters to users during login #6305

aetherfaerber opened this issue Nov 15, 2024 · 5 comments

Comments

@aetherfaerber
Copy link

Is your feature request related to a problem? Please describe.
On the login screen, the password field obfuscates the entered characters. This is good for scenarios, where possible bystanders could read a password while it is typed in. But it makes it harder for users to type passwords as they cannot check for possible typos.

Describe the solution you'd like
It is considered good practice to have a small eye-button at the end of the password field. Clicking that button allows users to switch from a obfuscated password display to a clear display on the entered characters. Users can control this depending on the situation (are they alone in their office) and their need for typo-checking.

Describe alternatives you've considered
Copy-pasting passwords is cumbersone and error-prone on its own.

Additional context
Apparently their are bigger issues(#456) concerning handling of passwords in Kitodo but this is out of scope here. This issue is only concerned with the display of passwords towards users in the login form.

@stweil
Copy link
Member

stweil commented Nov 15, 2024

I know two variants of this eye button:

  1. A switch button toggles between obfuscated and clear password display each time when the button is pressed.
  2. A push button enables the clear password display only when it is pressed.

I think the 2nd variant is more secure. Would it be sufficient?

@solth
Copy link
Member

solth commented Nov 15, 2024

I would suggest to implement this feature after #5528 has been finished, because PrimeFaces 10 (we currently still use version 8) introduced a toggleMask feature for password fields for exactly this purpose (see https://www.primefaces.org/showcase/ui/input/password.xhtml?jfwid=27de8). I would prefer using build-in options like this whenever available.

@aetherfaerber
Copy link
Author

I know two variants of this eye button:

  1. A switch button toggles between obfuscated and clear password display each time when the button is pressed.
  2. A push button enables the clear password display only when it is pressed.

I think the 2nd variant is more secure. Would it be sufficient?

I'm fine with both options, with a slight preference for the first variant as it seems more comfortable to use and I don't expect any regular onlookers in the first place. But there may be other scenarios where screen security is more important.

@aetherfaerber
Copy link
Author

I would suggest to implement this feature after #5528 has been finished, because PrimeFaces 10 (we currently still use version 8) introduced a toggleMask feature for password fields for exactly this purpose (see https://www.primefaces.org/showcase/ui/input/password.xhtml?jfwid=27de8). I would prefer using build-in options like this whenever available.

Thank you for pointing this out. Your suggestion is quite reasonable.

@aetherfaerber
Copy link
Author

The changes proposed here should also be applied to the respective fields in the dialog box to change a user's password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants