Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misnomer: Rename ConfigCore and ParameterCore #4032

Open
matthias-ronge opened this issue Oct 8, 2020 · 1 comment
Open

Misnomer: Rename ConfigCore and ParameterCore #4032

matthias-ronge opened this issue Oct 8, 2020 · 1 comment
Labels
improvement

Comments

@matthias-ronge
Copy link
Collaborator

The classes ConfigCore and ParameterCore are unintuitively named. These are not two kinds of cores, but one is the config and the other is an enum of parameters of the core.

Goal: Reverse names to CoreConfig and CoreParameter.
@matthias-ronge
Copy link
Collaborator Author

By the way: Is there a reason that we even need a ConfigCore class? This is a subclass of Config and actually all methods for accessing the configuration should be in class Config and then it should be good, right?

@solth solth removed the 3.x label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthias-ronge @solth