Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation warning: The structure has no media assigned: PeriodicalIssue "null" #3434

Closed
andre-hohmann opened this issue Apr 14, 2020 · 11 comments · Fixed by #3924 or #4702
Closed

Validation warning: The structure has no media assigned: PeriodicalIssue "null" #3434

andre-hohmann opened this issue Apr 14, 2020 · 11 comments · Fixed by #3924 or #4702

Comments

@andre-hohmann
Copy link
Collaborator

andre-hohmann commented Apr 14, 2020

Problem

For processes of newspaper-issues the following warning is shown:
The structure has no media assigned: PeriodicalIssue "null"

This leads to problems during the export.

Solution

The images of the process should be assigned automatically to the element "PeriodicalIssue". Otherwise, the images have to be assigned manually, which is quite time-consuming.

Example

validationwarning01

@matthias-ronge
Copy link
Collaborator

matthias-ronge commented Apr 14, 2020

The validation criticized that no images are assigned to the “unknown structure type” root element. In this case, that's correct, it shouldn't. So the validation is wrong.

To do:

  • correct validation, for included structural element with type null, do not check.
  • Second: warn message should not be green. Either it also turns red, or maybe a yellow hue. → Extracted to Warn message should not be green #3925
  • In addition: “unknown structure type” is incorrect. It is not unknown (in that case it would be yellow, with an exclamation mark), but without a type. Change text to “[Untyped]” → Extracted to Misnomer: Untyped structure type is labeled unknown #3926

@andre-hohmann
Copy link
Collaborator Author

The validation is correct, because the images should be assigned to the element "PeriodicalIssue".
After i did it manually, the validation warning was not shown anymore.

However, the assignment of the images to the element "PeriodicalIssue" has to be done automatically!! Otherwise, it takes a long time to finish the processes.

@matthias-ronge
Copy link
Collaborator

Okay, then that's something else again, and what I've described above is what the error #3435 is.

Should the assignment only happen if there is only one issue in the process? What if there are multiple issues in the process?

@andre-hohmann
Copy link
Collaborator Author

That is a good question. We work in the SLUB only with one issue per process and as this is an requirement by the DFG, i think most will use it that way. So important is:
If only one issue is in the process: All images are assigned to the element "PeriodicalIssue"

Otherwise:
If several issues in the process: No images is assigned to any element
Corrections of wrong assigned images are more time consuming then a correct initial assignment.
If we find a better solution, we can apply it. That should depend on the amout of its application.

@Kathrin-Huber
Copy link
Contributor

Is this still a problem? we had some fixes in the assignment in the meta.xml , maybe this is fixed too?

@andre-hohmann
Copy link
Collaborator Author

It is still a problem: The images have still to be assigned manually to the issue.
Otherwise, the error message is shown.

@matthias-ronge
Copy link
Collaborator

Goal:

the assignment of the images to the element "PeriodicalIssue" has to be done automatically!! Otherwise, it takes a long time to finish the processes.
If only one issue is in the process: All images are assigned to the element "PeriodicalIssue"
If several issues in the process: No images is assigned to any element

@andre-hohmann
Copy link
Collaborator Author

@matthias-ronge , it seems as if the assignment does not work. As the error messages are not shown (#4081), it is difficult to identify the other problems.

In the preview system, the following process has been created and all images are in "Unstructed media".

  • ElbefRiS_1666403997-20201102 - ID: 3575

@andre-hohmann andre-hohmann reopened this Nov 26, 2020
@Kathrin-Huber
Copy link
Contributor

But isn't this a problem not just for newspapers? When structuring a Monografie, all images are also added to "unstructred" until they are assigned to the specific structural element. As I understood it, that's what the Metadataeditor is for ;-)
How am I supposed to know, where to add the media to?

@andre-hohmann
Copy link
Collaborator Author

andre-hohmann commented Sep 27, 2021

The basic problem is not that the images are added to the section "Unstructred media", because then, the images are assigned automatically to the first-level structure element, for example monograph or volume.

For newspapers, the problem is the following one:
There are two levels of "Division without type" to which no images can be assigned to, because they represent the month/day-level. However the images of "Unstructred media" are automatically assigned to the "Division without type".
This leads to the error message The structure has no media assigned: PeriodicalIssue "null", because " PeriodicalIssue" is the first level of the structure elements to which images can be assigned to.
This has to be done manually and is very time consuming.

matthias-ronge added a commit to matthias-ronge/kitodo-production that referenced this issue Sep 27, 2021
@matthias-ronge
Copy link
Collaborator

I agree that this should be handled automatically.

matthias-ronge added a commit to matthias-ronge/kitodo-production that referenced this issue Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants