feat(developer): Windows package installer compiler 🎺 #9607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces kmcomp's package installer build infrastructure. While this is mostly legacy, package installers are still used in adhoc distribution scenarios, so we need to continue to support with the new kmc. The package installer is a Windows self-extracting zip archive. The user is expected to find setup-redist.exe and keymandesktop.msi themselves, from the Keyman Developer release files. They are not included with Keyman Developer, but are available as standalone downloads from https://downloads.keyman.com/windows/. `kmc build` has been updated to include two subcommands: * `kmc build ldml-test-data` * `kmc build windows-package-installer` Both of these subcommands are a little long, but the use cases for them are fairly narrow, so I believe this is okay. `kmc build-test-data` has been removed, as `kmc build ldml-test-data` replaces it.
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
developer/
common/
developer/compilers/
common/web/
feat
labels
keymanapp-test-bot
bot
changed the title
keymanapp-test-bot
bot
removed
the
user-test-missing
mcdurdin
requested review from
darcywong00,
jahorton and
rc-swag
as code owners
Base automatically changed from
feat/developer/remove-kmcmpdll
to
epic/package-metadata
October 3, 2023 13:35
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9538.
Replaces kmcomp's package installer build infrastructure. While this is mostly legacy, package installers are still used in adhoc distribution scenarios, so we need to continue to support with the new kmc.
The package installer is a Windows self-extracting zip archive. The user is expected to find setup-redist.exe and keymandesktop.msi themselves, from the Keyman Developer release files. They are not included with Keyman Developer, but are available as standalone downloads from https://downloads.keyman.com/windows/.
kmc buildhas been updated to include two subcommands:kmc build ldml-test-datakmc build windows-package-installerBoth of these subcommands are a little long, but the use cases for them are fairly narrow, so I believe this is okay.
kmc build-test-datahas been removed, askmc build ldml-test-datareplaces it.@keymanapp-test-bot skip