Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test case to compare Period04 results to Pyriod (and other packages) #1

Open
hippke opened this issue Jul 19, 2019 · 1 comment

Comments

@hippke
Copy link

hippke commented Jul 19, 2019

Fantastic package!

Part of the variable star community considers Period04 as the "ground truth" and suspects software with even slightly different results to contain bugs. I'm not sure if that is wise, but what do you think about a set of test cases? We could compare the FFT frequencies calculated from various packages, such as:

  • astropy
  • scipy
  • pyriod
  • period04
  • ?
@keatonb
Copy link
Owner

keatonb commented Jul 19, 2019

Thanks, I agree that this is a good idea. The results should certainly agree. The analysis in the example notebook has been compared to other pipelines preferred by various members of the TASC Working Group 8.2 and shows excellent agreement. Thanks for opening the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants