RPC: add client side ids to notification listeners. #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-stream-messages
Codecov Report
@@ Coverage Diff @@
## dev #2085 +/- ##
==========================================
+ Coverage 59.19% 59.54% +0.34%
==========================================
Files 678 678
Lines 32831 33071 +240
==========================================
+ Hits 19434 19691 +257
+ Misses 10596 10527 -69
- Partials 2801 2853 +52
Continue to review full report at Codecov.
|
…otificationMessage`
This was referenced Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this has been requested by devs in the discord development channel, specfically for kdx, and perhaps for usage in the vitex gateway?
it allows, for example, kaspad clients which handle multiple users, to differentiate the kaspad stream responses specific for each user.
To Do:
Register...WithIdto kaspad rpcclient, for id usage in the native client.on a further note, it can be used to perhaps create a new listener with each id requested, but may be for further development based on this pr, but beyond the scope of this pr itself.
I also hope some of the code can be used for future rpc reworks.
Note: currently I believe this only works for situations where clients intiate a seperate rpc connection, for each notification stream.