Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envsubst: command not found on hack/deploy-karmada.sh on macOS #5934

Open
hongshaoyang opened this issue Dec 10, 2024 · 3 comments
Open

envsubst: command not found on hack/deploy-karmada.sh on macOS #5934

hongshaoyang opened this issue Dec 10, 2024 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@hongshaoyang
Copy link

hongshaoyang commented Dec 10, 2024

What happened:

Failed to install karmada using hack/local-up-karmada.sh. logs:

writing RSA key
namespace/karmada-system created
/var/folders/_l/5q7qp9n17h99q52jg840_7b00000gp/T/tmp.hsQeEYHa
hack/../hack/deploy-karmada.sh: line 141: envsubst: command not found

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

  1. git clone https://github.com/karmada-io/karmada
  2. run hack/local-up-karmada.sh

Anything else we need to know?:

envsubst is part of GNU gettext which is not available on macOS. brew install gettext is required.

See snippet:

envsubst < "${REPO_ROOT}"/artifacts/deploy/karmada-cert-secret.yaml > "${TEMP_PATH}"/${name}-cert-secret.yaml

Environment:

  • Karmada version: latest master
  • kubectl-karmada or karmadactl version (the result of kubectl-karmada version or karmadactl version): karmadactl version: version.Info{GitVersion:"v0.0.0-master", GitCommit:"unknown", GitTreeState:"unknown", BuildDate:"unknown", GoVersion:"go1.23.3", Compiler:"gc", Platform:"darwin/arm64"}
  • Others: macOS Ventura 13.6.7 (22G720)
@hongshaoyang hongshaoyang added the kind/bug Categorizes issue or PR as related to a bug. label Dec 10, 2024
@RainbowMango
Copy link
Member

cc @chaosi-zju

@hongshaoyang hongshaoyang changed the title envsubst: command not found on hack/deploy-karmada.sh envsubst: command not found on hack/deploy-karmada.sh on macOS Dec 11, 2024
@chaosi-zju
Copy link
Member

chaosi-zju commented Dec 11, 2024

Thank you very much to point out this issue ! 👍

We're gonna fix that right now.

Or would you like to contribute a PR to Karmada to fix it ?

@hongshaoyang
Copy link
Author

I will leave it to your team to fix, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: No status
Development

No branches or pull requests

3 participants