Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from deprecated methods and to new controllers.. #617

Open
burmanm opened this issue Feb 27, 2024 · 1 comment · May be fixed by #740
Open

Migrate from deprecated methods and to new controllers.. #617

burmanm opened this issue Feb 27, 2024 · 1 comment · May be fixed by #740
Assignees
Labels
enhancement New feature or request refactoring

Comments

@burmanm
Copy link
Contributor

burmanm commented Feb 27, 2024

What is missing?

controller-runtime has been updated quite a lot since our last update and has following changes.

  • admission.Validator is deprecated and replaced with CustomValidator. We need to move to that.
  • ObjectReconciler is created, thus we can reduce the amount of boilerplate from our reconciler
  • Verify if some bugged tests can be re-enabled
  • "k8s.io/utils/pointer" is deprecated, use k8s.io/utils/ptr
  • /metrics can be secured with TLS
  • "sigs.k8s.io/controller-runtime/pkg/config/v1alpha1" is deprecated, remove and replace its usage
  • We can allow pprof for easier debugging/profiling of cass-operator, check Manager.Options.PprofBindAddress
  • Use reconcile.TerminalError(...) instead of just bailing out without error

Why is this needed?

controller-runtime is quite aggressive in removing deprecated methods and as such we need to keep up with the changes. Also, some of these are making our life easier.

┆Issue is synchronized with this Jira Story by Unito
┆Issue Number: CASS-11

@burmanm
Copy link
Contributor Author

burmanm commented Jul 12, 2024

Also, we need to move away from the controller-runtime YAML config as it was removed in 0.18.0.

@burmanm burmanm linked a pull request Dec 19, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant