From 6dacb087e5e93b16d900e5f99089ec176ad1dcfe Mon Sep 17 00:00:00 2001 From: Ben Siggery <14013357+siggerzz@users.noreply.github.com> Date: Tue, 19 Nov 2024 10:25:33 +0000 Subject: [PATCH] WCP-2562: bump cookie banner to 1.x (#223) * wcp-000: bump cookie banner to 1.0.0 * wcp-000: revert change * wcp-000: remove old cookie-banner dep * wcp-000: remove old cookie-banner dep * wcp-000: fix yarn lock * fix: DSW-2562 update vite to fix cookie banner in vanilla-app * copy locales to dist * chore: DSW-2562 use latest webc snapshot version * fix turbo * update cookie-banner * update cookie-banner * update yarn.lock * update browserstack device version * update to latest cookie-banner version * revert vite --------- Co-authored-by: Ben Siggery --- nextjs-app-v14/package.json | 3 +- .../cookie-banner/cookie-banner.tsx | 6 +- nuxt-app/package.json | 3 +- nuxt-app/pages/components/cookie-banner.vue | 5 +- turbo.json | 1 + vanilla-app/js/cookie-banner.js | 4 +- vanilla-app/package.json | 3 +- wdio.conf.js | 2 +- yarn.lock | 5235 +++++++---------- 9 files changed, 2075 insertions(+), 3187 deletions(-) diff --git a/nextjs-app-v14/package.json b/nextjs-app-v14/package.json index 6b6e1c2e..6d4b2804 100644 --- a/nextjs-app-v14/package.json +++ b/nextjs-app-v14/package.json @@ -14,10 +14,9 @@ "upgrade-pie-packages": "npx npm-check-updates \"@justeattakeaway/pie-*\" -u" }, "dependencies": { - "@justeattakeaway/pie-cookie-banner": "0.26.5", "@justeattakeaway/pie-css": "0.13.0", "@justeattakeaway/pie-icons-webc": "0.25.1", - "@justeattakeaway/pie-webc": "0.5.42", + "@justeattakeaway/pie-webc": "0.5.53", "@lit-labs/nextjs": "0.2.0", "@lit/react": "1.0.5", "next": "14.2.3", diff --git a/nextjs-app-v14/src/app/components/cookie-banner/cookie-banner.tsx b/nextjs-app-v14/src/app/components/cookie-banner/cookie-banner.tsx index add3bbca..94a3138b 100644 --- a/nextjs-app-v14/src/app/components/cookie-banner/cookie-banner.tsx +++ b/nextjs-app-v14/src/app/components/cookie-banner/cookie-banner.tsx @@ -2,16 +2,14 @@ import NavigationLayout from "@/app/layout/navigation"; import { PieCookieBanner } from '@justeattakeaway/pie-webc/react/cookie-banner.js'; -// TODO: Remove this comment as soon as we provide the TS declaration for locales -// @ts-ignore: missing declaration for locales -import daDK from '@justeattakeaway/pie-cookie-banner/locales/da-dk.json'; export default function CookieBanner() { return ( diff --git a/nuxt-app/package.json b/nuxt-app/package.json index 5b4cc505..573957e0 100644 --- a/nuxt-app/package.json +++ b/nuxt-app/package.json @@ -19,10 +19,9 @@ "sass": "1.70.0" }, "dependencies": { - "@justeattakeaway/pie-cookie-banner": "0.26.5", "@justeattakeaway/pie-css": "0.13.0", "@justeattakeaway/pie-icons-webc": "0.25.1", - "@justeattakeaway/pie-webc": "0.5.42", + "@justeattakeaway/pie-webc": "0.5.53", "just-kebab-case": "4.2.0", "nuxt-ssr-lit": "1.6.16" }, diff --git a/nuxt-app/pages/components/cookie-banner.vue b/nuxt-app/pages/components/cookie-banner.vue index e12954e8..75958098 100644 --- a/nuxt-app/pages/components/cookie-banner.vue +++ b/nuxt-app/pages/components/cookie-banner.vue @@ -1,6 +1,6 @@