Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow improvements #7545

Open
jtpio opened this issue Dec 20, 2024 · 2 comments · Fixed by #7548 or #7552 · May be fixed by #7556
Open

Update workflow improvements #7545

jtpio opened this issue Dec 20, 2024 · 2 comments · Fixed by #7548 or #7552 · May be fixed by #7556
Labels
maintenance status:Needs Triage Applied to issues that need triage
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Dec 20, 2024

Tracking improvements for the workflow to update to newer JupyterLab versions: https://github.com/jupyter/notebook/actions/workflows/upgrade-juypterlab-dependencies.yml

The workflow was originally added in #7281.

  • open the PR automatically
  • use the github-actions user to open the PR

Image

  • some logic to bump the dependency on the jupyterlab Python package. At least when we update to a new minor version. Or make that configurable in the workflow.

requires = ["hatchling>=1.11", "jupyterlab>=4.3.2,<4.4"]

"jupyterlab>=4.3.2,<4.4",

Example PR which updated to a patch release: https://github.com/jupyter/notebook/pull/7527/files

@jtpio
Copy link
Member Author

jtpio commented Dec 21, 2024

Re-opening to track more improvements:

"@jupyterlab/galata": "~5.3.2",

@jtpio jtpio reopened this Dec 21, 2024
@jtpio jtpio added this to the 7.4.0 milestone Dec 21, 2024
@jtpio
Copy link
Member Author

jtpio commented Dec 21, 2024

More cases to consider:

  • handle pre-release cycles. Currently main is on JupyterLab 4.4.0a1, but the latest version as retrieved by the script will be 4.3.4. So it should first check if the target branch is using a pre-release, and make sure updates are for newer versions
  • we should ideally be able to run the workflow for other backport branches to, for example to update 7.3.x while main is still targeting 7.4.0

@jtpio jtpio reopened this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance status:Needs Triage Applied to issues that need triage
Projects
None yet
1 participant