Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check specific data file, not the parent folder #27

Open
brfi3983 opened this issue Sep 2, 2024 · 0 comments
Open

Check specific data file, not the parent folder #27

brfi3983 opened this issue Sep 2, 2024 · 0 comments

Comments

@brfi3983
Copy link
Collaborator

brfi3983 commented Sep 2, 2024

https://github.com/jouvetg/igm/blob/bf635958b8e9c5aff019b7ada2a215d48a0cc3b4/igm/common.py#L436C1-L436C40

In the current implementation, even if you have different names for each of your input.nc files, it will not download the new data as it only checks the parent folder data. Instead, download the data but save it to a more specific filename such as aletsch_basic.nc and then check if that specific file exists, not the folder.

This can be done by changing the name of the input.nc file to the specific name in the cloud and then reading that name within the python script before doing the checks.

Lastly, change the print() in the else code block to a raise() call for a more robust error handling and correct the following typo: The data already existing at {folder_name} -> The data already exists at {}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant