Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_requires in setup.py #24

Open
fmaussion opened this issue Aug 26, 2024 · 0 comments
Open

install_requires in setup.py #24

fmaussion opened this issue Aug 26, 2024 · 0 comments

Comments

@fmaussion
Copy link
Contributor

A few quick comments out of the tutorial: install_requires in setup.py seems too strict (at least on Mac). I just managed to run IGM on Mac with a "non compatible" version of python (3.11) and tensorflow.

In general I would rather suggest keeping the list of requires but remove the version pins, unless absolutely necessary. This way users can define the env the way they want and still install igm without having to fiddle around with setup.py. Providing environment files (requirements.txt or similar) could be a way to help as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@fmaussion and others