Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to pre-install pre-commit hooks #1

Open
jopetty opened this issue Mar 1, 2022 · 0 comments
Open

Figure out how to pre-install pre-commit hooks #1

jopetty opened this issue Mar 1, 2022 · 0 comments

Comments

@jopetty
Copy link
Owner

jopetty commented Mar 1, 2022

Currently, in order to actually use the pre-commit hooks we have to remember to install them every time the docker image is recreated. It would be better if this could be done as a step in the Dockerfile and just cache it.

I think the big difficulty, however, is that we don't actually have the .git info for the repo when the Docker image is built, since we're MOUNTing it in via the devcontainer.json, so any attempt to install the hooks early (as in here) will fail when the new .git folder is copied over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant