Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move functions to separate SCSS file #94

Open
C-Lodder opened this issue Aug 16, 2018 · 7 comments
Open

Move functions to separate SCSS file #94

C-Lodder opened this issue Aug 16, 2018 · 7 comments

Comments

@C-Lodder
Copy link
Contributor

https://github.com/joomla-projects/custom-elements/blob/master/src/scss/alert/alert.scss#L7-L27

same applies for mixins just a few lines down

@ciar4n
Copy link
Contributor

ciar4n commented Aug 16, 2018

+1 from me

@N6REJ
Copy link

N6REJ commented Oct 9, 2020

@C-Lodder how would I go about doing this? I don't see a master scss file so I'm not sure how the scss is being built.
nor do I see how to test

@C-Lodder
Copy link
Contributor Author

C-Lodder commented Oct 9, 2020

@N6REJ Copy/paste the mixins and functions into a new CSS file, and import that file in alert.scss
Although you should probably consider moving away from SCSS

@N6REJ
Copy link

N6REJ commented Oct 10, 2020

why move AWAY from scss? thought we were moving TO scss?

@N6REJ
Copy link

N6REJ commented Oct 10, 2020

Draft PR #148

@C-Lodder
Copy link
Contributor Author

Cause PostCSS is the present and future ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants