Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joomla-tab createNavs and removeNavs will never Execute #240

Open
Weiskopfseeadler opened this issue Nov 26, 2024 · 0 comments · May be fixed by #241
Open

joomla-tab createNavs and removeNavs will never Execute #240

Weiskopfseeadler opened this issue Nov 26, 2024 · 0 comments · May be fixed by #241

Comments

@Weiskopfseeadler
Copy link

the function createNavs and removeNavs can not execute becaus of the fihrst if

if ((tab instanceof Element && tab.tagName.toLowerCase() !== 'joomla-tab-element') || ![].some.call(this.children, (el) => el === tab).length || !tab.getAttribute('name') || !tab.getAttribute('id')) return;
The problem is with
![].some.call(this.children, (el) => el === tab).length
some returns true or fals and does not have length. Therfor it is always true.
Remove lenth and it will work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant