-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusion and caching issues #25
Comments
I would not recommend doing this. Not only will this cause users to clone the large vcpkg repository, it also means that the users will not get the most up to date version of vcpkg.
This action runs the manifest build separately and then uses Using this action may not be the best choice for your scenario. You can directly use vcpkg caching: https://learn.microsoft.com/en-us/vcpkg/users/binarycaching#gha |
Thanks. I've almost got this working, but when I bring in I suspect the problem may be that the action is invoking I guess that means I'll have to ditch your action and figure out the caching stuff you linked. |
Update: Got caching working with vcpkg invoked via CMake - thanks again! Working YAML: https://github.com/HunterZ/rustLaunchSite/blob/06728d65ba42cf7fda7738c656a137c5fb53806a/.github/workflows/rustLaunchSite.yml Ran with an empty cache, then ran again. vcpkg reported use of cache, and workflow time dropped by about 6 minutes:
|
Got this working, but I don't think it's caching my stuff. Meanwhile, I am confused about some aspects of it:
First, other stuff I've read encourage me to pull in vcpkg as a submodule of my project, but this Action wants to clone vcpkg into the runner workspace instead, so I had to use a workaround to init all submodules except vcpkg. Would it be possible for this Action to support using vcpkg as a submodule? (Edit: I've backed out of using it as a submodule for now, since I wasn't thrilled about it in the first place)
Second, I'm confused about
steps.vcpkg.outputs.vcpkg-cmake-config
:steps.vcpkg.outputs.vcpkg-cmake-config
for caching to work?Third, caching doesn't seem to be working consistently. For example, this workflow run on the final commit to my CI/CD development branch completed in 3 minutes:
https://github.com/HunterZ/rustLaunchSite/actions/runs/7947199387/job/21695744049
...but this workflow run over the same git repo contents after merging my branch to
main
took over 13 minutes, which is twice as long as running vcpkg without an Action:https://github.com/HunterZ/rustLaunchSite/actions/runs/7947262070/job/21695877873
Is there something I'm doing wrong? Here is my workflow YAML:
https://github.com/HunterZ/rustLaunchSite/blob/9fb24d8d63dabdbed5e4865a4ebe241fb0629c10/.github/workflows/rustLaunchSite.yml
The text was updated successfully, but these errors were encountered: