Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Replace the Test Host Level DB's with containers. #919

Open
bearrito opened this issue Mar 22, 2024 · 1 comment
Open

[Proposal] Replace the Test Host Level DB's with containers. #919

bearrito opened this issue Mar 22, 2024 · 1 comment

Comments

@bearrito
Copy link

It looks like the unit tests for this project require installing host level db instances. That's reasonable given the projects inception date.

However, I think there are better alternatives available.

Namely using https://github.com/testcontainers/testcontainers-go

Advantages

  1. Less overhead for development (If actually ongoing in this project)
  2. Easier to test within a vendors versions eg. we could have Postgres 12-16
  3. Easier to test across vendors e.g Mysql, Maria, Postgres, MSSQL etc.

If the maintainers accepted this I would contribute the suite.

@stephen-up
Copy link

As a user of this lib who was thinking about adding test coverage for clickhouse. This would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants