Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slices.Delete #10

Open
Deleplace opened this issue Sep 20, 2023 · 0 comments
Open

slices.Delete #10

Deleplace opened this issue Sep 20, 2023 · 0 comments

Comments

@Deleplace
Copy link

Deleplace commented Sep 20, 2023 •
edited
Loading

Hello, while researching for this Go proposal I noticed this code:

slices.Delete(dependency.Dependents, dependentIndex, dependentIndex + 1)

which probably doesn't behave as intended because the returned value of slices.Delete is ignored.

Deleting elements inside the range dependency.Dependents loop is tricky to reason about, so I would suggest using slices.DeleteFunc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Deleplace