-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification of Coordinate Systems in Documentation #63
Comments
Thanks! |
[-pi, pi]. |
And for angular velocities? Rad/s? |
Yep! |
I think I've found my issue. It is related to the network outputs, rather than inputs. |
Are you intending to output to a crazyflie IRL? If the policy was trained in one of the gym envs within PyFlyt, the outputs should be "roll, pitch, yaw, theust" (v-pqr, T). The rotational outputs always follow the axes of the linear frames. If your intended goal is to output to a crazyflie, then it is likely in the form of "pitch, roll, yaw, thrust". I would try isolating outputs (by setting everything else to 0), and then activating only one output. |
@jet-sony just to clarify what you said above, are you saying that if we trained a model within the environment the model should output int the order of "roll, pitch, yaw, thrust" and so if i take this model and try to control an actual crazyflie drone i should change the order from "roll, pitch, yaw, thrust" to "pitch, roll, yaw, thrust"? |
@zcase it's been awhile since I've messed with crazyflies. What I will say is that the output space in PyFlyt is permuted in Crazyflies. I would refer to the official documentation for the most up to date material. CrazyFlyt is simply a simple wrapper around both these libraries. |
Hi,
I am trying to deploy a learned controller from PyFlyt onto a real quadcopter running Ardupilot. As far as I can tell these two use different coordinate system conventions. Namely: PyFlyt uses ENU (which means on the body of the drone its forward is X, to the left is Y and up is Z; Ardupilot uses NED (i.e. forward X, right Y and Z down). Is this correct thus far?
Also, I am unsure about the direction of rotation for yaw pitch roll in PyFlyt. Looking at the illustration provided in the paper, which way is a positive roll for example?
Ideally, the image containing this information should provided in the documentation.
Thanks!
The text was updated successfully, but these errors were encountered: