🐛 URLs (external links) require additional urldecoding

[ToshY]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

URLs, in this case "Resources" (also referred as "External links") can contain links to sites that have japanese characters in the URL path.

Example: https://api.jikan.moe/v4/anime/21/full

Results for external are the following:

• Wikipedia: https://ja.wikipedia.org/wiki/ONE_PIECE_%28%E3%82%A2%E3%83%8B%E3%83%A1%29
• Baidu Baike: https://baike.baidu.com/item/%E8%88%AA%E6%B5%B7%E7%8E%8B/6616881

Expected Behavior

• Wikipedia: https://ja.wikipedia.org/wiki/ONE_PIECE_(アニメ)
• Baidu Baike: https://baike.baidu.com/item/航海王/6616881

Steps To Reproduce

https://api.jikan.moe/v4/anime/21/full

Environment

jikan-me/jikan: 5.0.0-dev

Anything else?

Workaround

Manually urldecode the URLs that jikan returns.

---

Edit

For some, this would also require mb_encoding_check, as apparently some URLs use Shift JIS (and possible other encodings). If not converted with mb_convert_encoding, this can cause errors like General error: 1366 Incorrect string value when inserting into a SQL database.

https://api.jikan.moe/v4/anime/28353/full

snippet

    public function urlDecodeWithMbConvertEncoding(?string $url): string
    {
        $decodedString = urldecode($url);
        foreach (['UTF-8', 'SJIS', 'ISO-8859-1', 'Windows-1252'] as $encoding) {
            if (mb_check_encoding($decodedString, $encoding) === false) {
                continue;
            }

            return mb_convert_encoding($decodedString, 'UTF-8', $encoding);
        }

        return $decodedString;
    }