Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlib ensure_package? #66

Open
jcpunk opened this issue Feb 26, 2016 · 2 comments
Open

stdlib ensure_package? #66

jcpunk opened this issue Feb 26, 2016 · 2 comments

Comments

@jcpunk
Copy link

jcpunk commented Feb 26, 2016

Should the package{} items be shifted to ensure_package from stdlib?

@jhoblitt
Copy link
Owner

That wouldn't hurt but using ensure_package() instead of ensure_resources() is dependent on whether or not the allow_virtual param can be removed. I believe that was added to silence a warning introduced in puppet 3.6.x, that has since been removed. Eg

allow_virtual => false,

@jhoblitt
Copy link
Owner

allow_virtual has been removed but the ensure param is now being used. A PR to convert to ensure_resources() would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants