-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid frogbot from overwriting the comment section as part of every scan #511
Comments
There isn't currently @nx2804. |
yes please. for example we have multiple pipelines included in the pr validation step so as part of every pipeline run the frogbot is overwriting the comments . instead we wanted to retain the existing comment and frogbot to add new comment on top it |
any update on this please |
@nx2804, |
Sure thanks it would be great if you can make this available asap
…On Fri, 22 Sep 2023 at 10:27 PM, Eyal Ben Moshe ***@***.***> wrote:
@nx2804 <https://github.com/nx2804>,
Thank you for sharing this requirement.
I believe we can add a new variable that to make Frogbot skip the deletion
of old comments added by Frogbot on PRs.
Let us update this issue once we add this functionality.
—
Reply to this email directly, view it on GitHub
<#511 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCAEUMFUKZRWWAXXQUBIHBTX3W7OZANCNFSM6AAAAAA5ADTMCI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Any update on this request
On Fri, 22 Sep 2023 at 10:52 PM, Nachammai Chidambaram <
***@***.***> wrote:
… Sure thanks it would be great if you can make this available asap
On Fri, 22 Sep 2023 at 10:27 PM, Eyal Ben Moshe ***@***.***>
wrote:
> @nx2804 <https://github.com/nx2804>,
> Thank you for sharing this requirement.
> I believe we can add a new variable that to make Frogbot skip the
> deletion of old comments added by Frogbot on PRs.
> Let us update this issue once we add this functionality.
>
> —
> Reply to this email directly, view it on GitHub
> <#511 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BCAEUMFUKZRWWAXXQUBIHBTX3W7OZANCNFSM6AAAAAA5ADTMCI>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Hi @nx2804, |
Azure repos and azure devops pipeline
We have a consolidated pr which has all individual build validation ci
triggered together
…On Fri, 29 Sep 2023 at 4:07 PM, Michael Sverdlov ***@***.***> wrote:
Hi @nx2804 <https://github.com/nx2804>,
Could you please provide further details about your Git provider and CI
server setup? Additionally, could you clarify why the frogbot is triggered
for every pipeline? Ideally, we'd like frogbot to be triggered only when a
new commit is made to the pull request.
Thank you!
—
Reply to this email directly, view it on GitHub
<#511 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCAEUMAW7SBPD4AKGHNBRZDX42QFJANCNFSM6AAAAAA5ADTMCI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
any updates on this please |
Hi @nx2804, We are pleased to announce the release of Frogbot v2.17.0, which incorporates this feature. To enable this feature, you can either set the environment variable as follows:
or update your Frogbot config by adding the
Please don't hesitate to reach out if you encounter any difficulties or have any questions. |
Hi
Thanks let me test and get back to you
…On Thu, 12 Oct 2023 at 3:24 PM, Assaf Attias ***@***.***> wrote:
Hi @nx2804 <https://github.com/nx2804>,
We are pleased to announce the release of Frogbot v2.17.0, which
incorporates this feature.
To enable this feature, you can either set the environment variable as
follows:
JF_AVOID_PREVIOUS_PR_COMMENTS_DELETION: "TRUE"
or update your Frogbot configuration by adding the scan parameter:
avoidPreviousPrCommentsDeletion: true
Please don't hesitate to reach out if you encounter any difficulties or
have any questions.
—
Reply to this email directly, view it on GitHub
<#511 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCAEUMF25BVFNAO2SA47CV3X6646HANCNFSM6AAAAAA5ADTMCI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi
This has solved the overwriting of comment problem but with latest version
of frogbot when i set JF_INCLUDE_ALL_VULNERABILITIES: TRUE it is not
displaying the vulnerabilities . Instead it always prints that the PR has
no issues
On Thu, 12 Oct 2023 at 15:51, Nachammai Chidambaram ***@***.***>
wrote:
… Hi
Thanks let me test and get back to you
On Thu, 12 Oct 2023 at 3:24 PM, Assaf Attias ***@***.***>
wrote:
> Hi @nx2804 <https://github.com/nx2804>,
>
> We are pleased to announce the release of Frogbot v2.17.0, which
> incorporates this feature.
>
> To enable this feature, you can either set the environment variable as
> follows:
>
> JF_AVOID_PREVIOUS_PR_COMMENTS_DELETION: "TRUE"
>
> or update your Frogbot configuration by adding the scan parameter:
>
> avoidPreviousPrCommentsDeletion: true
>
> Please don't hesitate to reach out if you encounter any difficulties or
> have any questions.
>
> —
> Reply to this email directly, view it on GitHub
> <#511 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BCAEUMF25BVFNAO2SA47CV3X6646HANCNFSM6AAAAAA5ADTMCI>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Currently frogbot is reporting issues in pull request but that doesn’t
display which pipeline has this issue during pull request scan
Say for example I have multiple pipelines included in build validations in
PR, the scan should report which pipeline has this issues
…On Tue, 24 Oct 2023 at 6:50 PM, Assaf Attias ***@***.***> wrote:
Hi @nx2804 <https://github.com/nx2804>,
I noticed that the issue at #541
<#541>, which you opened after
this current issue, has been marked as resolved. Could you please verify
this? Are there any other issues or concerns that need attention?
—
Reply to this email directly, view it on GitHub
<#511 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCAEUMDGS4PSPRLBUMLSYJTYA66CVAVCNFSM6AAAAAA5ADTMCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZXGE4TEOJTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @nx2804, we have recently received a similar feature request, which you can find here: #550. We are initiating the implementation of the new feature that will enable the addition of a custom header to pull request comments, such as the relevant pipeline, through an environment variable. I will keep you informed of our progress and notify you once Frogbot is released with this new feature. Thank you. |
Hi @nx2804, we have just released Frogbot v2.18.0, which includes the |
Sure will check and keep you posted
…On Wed, 25 Oct 2023 at 8:51 PM, Omer Zidkoni ***@***.***> wrote:
Hi @nx2804 <https://github.com/nx2804>, we have just released Frogbot
v2.18.0, which includes the JF_PR_COMMENT_TITLE environment variable.
With this environment variable, you can set a title for your pull request
scanning comments. Please let me know if this works for you. Thanks!
—
Reply to this email directly, view it on GitHub
<#511 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCAEUMEZXNXIILP3ZFUH5ATYBEU6FAVCNFSM6AAAAAA5ADTMCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZGUZDEMZUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
it works thanks
On Wed, 25 Oct 2023 at 23:41, Nachammai Chidambaram ***@***.***>
wrote:
… Sure will check and keep you posted
On Wed, 25 Oct 2023 at 8:51 PM, Omer Zidkoni ***@***.***>
wrote:
> Hi @nx2804 <https://github.com/nx2804>, we have just released Frogbot
> v2.18.0, which includes the JF_PR_COMMENT_TITLE environment variable.
> With this environment variable, you can set a title for your pull request
> scanning comments. Please let me know if this works for you. Thanks!
>
> —
> Reply to this email directly, view it on GitHub
> <#511 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BCAEUMEZXNXIILP3ZFUH5ATYBEU6FAVCNFSM6AAAAAA5ADTMCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZGUZDEMZUHE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Hi Team,
I wanted to know is there any variable to avoid frogbot being overwriting the comments in PR as part of every execution?
The text was updated successfully, but these errors were encountered: