Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid frogbot from overwriting the comment section as part of every scan #511

Closed
nx2804 opened this issue Sep 20, 2023 · 19 comments
Closed
Labels
question Further information is requested

Comments

@nx2804
Copy link

nx2804 commented Sep 20, 2023

Hi Team,

I wanted to know is there any variable to avoid frogbot being overwriting the comments in PR as part of every execution?

@nx2804 nx2804 added the question Further information is requested label Sep 20, 2023
@eyalbe4
Copy link
Contributor

eyalbe4 commented Sep 20, 2023

There isn't currently @nx2804.
Would you have used such a variable if we added it? Will you be able to share more info about the requirement and why such option be useful for you?

@nx2804
Copy link
Author

nx2804 commented Sep 21, 2023

yes please. for example we have multiple pipelines included in the pr validation step so as part of every pipeline run the frogbot is overwriting the comments . instead we wanted to retain the existing comment and frogbot to add new comment on top it

@nx2804
Copy link
Author

nx2804 commented Sep 22, 2023

any update on this please

@eyalbe4
Copy link
Contributor

eyalbe4 commented Sep 22, 2023

@nx2804,
Thank you for sharing this requirement.
I believe we can add a new variable that to make Frogbot skip the deletion of old comments added by Frogbot on PRs.
Let us update this issue once we add this functionality.

@nx2804
Copy link
Author

nx2804 commented Sep 22, 2023 via email

@nx2804
Copy link
Author

nx2804 commented Sep 25, 2023 via email

@sverdlov93
Copy link
Contributor

Hi @nx2804,
Could you please provide further details about your Git provider and CI server setup? Additionally, could you clarify why the frogbot is triggered for every pipeline? Ideally, we'd like frogbot to be triggered only when a new commit is made to the pull request.
Thank you!

@nx2804
Copy link
Author

nx2804 commented Sep 29, 2023 via email

@nx2804
Copy link
Author

nx2804 commented Oct 10, 2023

any updates on this please

@attiasas
Copy link
Contributor

attiasas commented Oct 11, 2023

Hi @nx2804, I'm currently working on this feature, and it will be available soon. You can follow its progress at #537

@attiasas
Copy link
Contributor

attiasas commented Oct 12, 2023

Hi @nx2804,

We are pleased to announce the release of Frogbot v2.17.0, which incorporates this feature.

To enable this feature, you can either set the environment variable as follows:

JF_AVOID_PREVIOUS_PR_COMMENTS_DELETION: "TRUE"

or update your Frogbot config by adding the scan parameter:

avoidPreviousPrCommentsDeletion: true

Please don't hesitate to reach out if you encounter any difficulties or have any questions.

@nx2804
Copy link
Author

nx2804 commented Oct 12, 2023 via email

@nx2804
Copy link
Author

nx2804 commented Oct 12, 2023 via email

@attiasas
Copy link
Contributor

Hi @nx2804,

I noticed that the issue at #541, which you opened after this current issue, has been marked as resolved. Could you please verify this? Are there any other issues or concerns that need attention?

@nx2804
Copy link
Author

nx2804 commented Oct 24, 2023 via email

@omerzi
Copy link
Member

omerzi commented Oct 25, 2023

Hi @nx2804, we have recently received a similar feature request, which you can find here: #550. We are initiating the implementation of the new feature that will enable the addition of a custom header to pull request comments, such as the relevant pipeline, through an environment variable. I will keep you informed of our progress and notify you once Frogbot is released with this new feature. Thank you.

@omerzi
Copy link
Member

omerzi commented Oct 25, 2023

Hi @nx2804, we have just released Frogbot v2.18.0, which includes the JF_PR_COMMENT_TITLE environment variable. With this environment variable, you can set a title for your pull request scanning comments. Please let me know if this works for you. Thanks!

@nx2804
Copy link
Author

nx2804 commented Oct 25, 2023 via email

@nx2804
Copy link
Author

nx2804 commented Oct 26, 2023 via email

@eyalbe4 eyalbe4 closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants