Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit not working + extra #225

Open
Anthropomorphed opened this issue Sep 7, 2023 · 15 comments
Open

Exit not working + extra #225

Anthropomorphed opened this issue Sep 7, 2023 · 15 comments
Labels
enhancement New feature or request

Comments

@Anthropomorphed
Copy link

Hey, i started using this bot 2 days ago.
I have to say, great bot! And how it is with all things we like, we want to improve it further! Here i go.

Main Issue:
the bot does not recognize when you are dead. It does not exit. I tried to check the code myself to fix it but without a lead i am lost.

Small issues + improvement ideas:

  • 2-3 sometimes stops recognizing champions and sells comp/early comp champs a round or two later.
  • Carousel, if by chance it gets comp champ, it sells it anyway.
  • 3-5 Bought 2 random champions. 1 to fill board, 1 to be sold again
  • Changed the spam roll to 45, as it starts rolling a round later. For below 30 it was way too tight, usually lost with 30+ gold within 2 rounds.
  • Item Priority (which champ to get item first) would be great + recognizing fully built items. I use TF for randomizing my item bench and sometimes i get a full item. Usually it gathers dust until i manually put it on a champ.
  • Additionally: Item recognition already on champ.
  • Item planing: I use Early/True comp. Being able to set the items to be reused from early comp to late comp would be great! No double building and item waste.
  • 5-5 Random champ bought and sold.

Once: 4-5 sold everything on bench. Probably because i looked at a different players board to check his build.

@anthony5301
Copy link
Collaborator

anthony5301 commented Sep 8, 2023

the bot does not recognize when you are dead

Already exist : game_function.py -> check_alive()

2-3 sometimes stops recognizing champions

Ocr didnt know that is new round (Recognition failure)

sells it anyway

The bot need to pop out the item in past few season. It is possible to do it but it cost lot of time to 1.right click that champ 2.recognize champ name 3.check if the name in list champs_to_buy 4.move cursor back to default pos 5.remove the champ from the list.

Item Priority

I did it before but not murged, check pr #100. btw im still using it.

Item planing

Sounds good but that is a heavy workloads.

@Anthropomorphed
Copy link
Author

Already exist : game_function.py -> check_alive()

Doesn't work. It just ran the entire night and not a single game it properly exited.
The game had to be finished to be auto-exited. It is getting each round the "Health check failed", but not exiting.

I would need some help to debug that issue, losing 10-25 minutes each game is a huge exp loss.

I did it before but not murged, check pr #100. btw im still using it.

Oh i see, nice, just have to rearrange then.

@anthony5301
Copy link
Collaborator

download the whole project and run install.py again
seems the bot cant read data from riot api

@anthony5301
Copy link
Collaborator

Hey, I've added the ability to check if unknown champ are in the comps. Could you help me test it? If there are no issues, I will push it to the main branch. My fork here

@anthony5301 anthony5301 added the enhancement New feature or request label Sep 22, 2023
@Arwen-JNeto
Copy link

I wanted to provide an update on the ongoing issue. Unfortunately, the bot is still failing to recognize when the user is considered 'dead,' and it continues to not exit as expected. Despite my best efforts to investigate and fix the problem by reviewing the code, I have not been able to make any significant progress.

@anthony5301
Copy link
Collaborator

I wanted to provide an update on the ongoing issue. Unfortunately, the bot is still failing to recognize when the user is considered 'dead,' and it continues to not exit as expected. Despite my best efforts to investigate and fix the problem by reviewing the code, I have not been able to make any significant progress.

The exit problem are fixed already, riot just moved the exit button to other position. Please download the bot again to get the newest file.

@Arwen-JNeto
Copy link

Arwen-JNeto commented Oct 19, 2023

For me, it still has the error, look at the image.
Captura de tela 2023-10-18 235617

Furthermore, it doesn't recognize and doesn't place the items on the champions, but that's not even that important.

@anthony5301
Copy link
Collaborator

For me, it still has the error, look at the image.

what is your monitor size?

@Arwen-JNeto
Copy link

1920x1080

@Arwen-JNeto
Copy link

Does it need to have a resolution of 1920x1080, the quality set to medium, and the window in borderless mode right?

@anthony5301
Copy link
Collaborator

Did you modify comps.py by yourself?
1366x768, 1920x1080, 2560x1440 and even 4k are ok.
and the quality doesnt matter.
yes must be in borderless mode.
For the exit problem try this fork

@Arwen-JNeto
Copy link

I haven't changed the composition, but I confess I plan to. Demacia is a bit weak, and I'm thinking of Bilgewater or Void. I'm also considering changing the star levels of the champions. The tanks need to reach level 3, especially since the items aren't working. Okay, I'll test this version.

The only thing I changed was the League installation location.

@anthony5301
Copy link
Collaborator

can you check if there is any messages about items in the bot history?
it will be in round x-2 and x-5 like this:
image

@Arwen-JNeto
Copy link

Arwen-JNeto commented Oct 19, 2023

1697688057457939331062097715309
Now it's giving this error...

One question, if my monitor is 1920x1080, does the client need to have the same resolution?

@anthony5301
Copy link
Collaborator

anthony5301 commented Oct 19, 2023

league client : no
in-game : yes

Now it's giving this error...

just restart it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants