Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests - 100% coverage would be ideal. #31

Open
jeffreydwalter opened this issue Dec 8, 2017 · 8 comments
Open

Add unit tests - 100% coverage would be ideal. #31

jeffreydwalter opened this issue Dec 8, 2017 · 8 comments

Comments

@jeffreydwalter
Copy link
Owner

Would be nice to have automated tests so we know the API is performing.

@Kerl1310
Copy link
Contributor

Added some initial unit test code to get this underway. Happy to implement more over time if the initial implementation passes review

@jeffreydwalter
Copy link
Owner Author

@Kerl1310 thank you so much! I REALLY appreciate your contributions. Is there anything we need to do to get your tests hooked up to a github action?

@Kerl1310
Copy link
Contributor

Theres a GitHub actions CI file included which should just work once it's merged with any luck. If not I can fix it if there are any issues

@jeffreydwalter
Copy link
Owner Author

I merged your changes and pushed a new release commit, but didn't see any indication that the tests ran. Can you check in master and see if it's running?

@jeffreydwalter
Copy link
Owner Author

Looks like you set it up to only run on pull request? Am I reading this right?

@jeffreydwalter
Copy link
Owner Author

@jeffreydwalter I added support for running on push to master as well. Thanks again! I REALLY appreciate your contribution and am happy for anything else you feel like adding!

@Kerl1310
Copy link
Contributor

Looks like the CI is running but it's having issues with the imports so the build is failing

@jeffreydwalter
Copy link
Owner Author

Yep! I was trying to figure it out, but don't really know how to fix it. If you have a few cycles to take a look I would be forever grateful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants