-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests - 100% coverage would be ideal. #31
Comments
Added some initial unit test code to get this underway. Happy to implement more over time if the initial implementation passes review |
@Kerl1310 thank you so much! I REALLY appreciate your contributions. Is there anything we need to do to get your tests hooked up to a github action? |
Theres a GitHub actions CI file included which should just work once it's merged with any luck. If not I can fix it if there are any issues |
I merged your changes and pushed a new release commit, but didn't see any indication that the tests ran. Can you check in master and see if it's running? |
Looks like you set it up to only run on pull request? Am I reading this right? |
@jeffreydwalter I added support for running on push to master as well. Thanks again! I REALLY appreciate your contribution and am happy for anything else you feel like adding! |
Looks like the CI is running but it's having issues with the imports so the build is failing |
Yep! I was trying to figure it out, but don't really know how to fix it. If you have a few cycles to take a look I would be forever grateful! |
Would be nice to have automated tests so we know the API is performing.
The text was updated successfully, but these errors were encountered: