Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll up not working without dunstify #3

Closed
thomas-forbes opened this issue Aug 29, 2021 · 7 comments
Closed

Scroll up not working without dunstify #3

thomas-forbes opened this issue Aug 29, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@thomas-forbes
Copy link

When you don't have dunstify installed the scroll up functionality described in the readme doesn't work. This is because when you ./polybar-timer.sh increase 60 you get ./polybar-timer.sh: line 20: dunstify: command not found and an error which means it will create a new timer overwriting the increase.

@jbirnick
Copy link
Owner

jbirnick commented Aug 29, 2021

Yes. That is also more or less mentioned in the README:

Inside the script dunstify is called to view the mentioned notification for the expiry time. But this is not necessary. (Just beautiful.) If you do not use Dunst then still everything (but the preview of the expiry time) will work fine without dependencies.

In that case you would have to edit the script yourself. I want to keep it as simple as possible, so I'm not going to introduce a config or anything.

For example you can modify the printExpiryTime and deleteExpiryTime functions so that they do nothing:

printExpiryTime () { :; }
deleteExpiryTime () { :; }

I will also add a link to this to the README, thank you.

@jbirnick jbirnick added documentation Improvements or additions to documentation question Further information is requested labels Aug 29, 2021
@jbirnick jbirnick pinned this issue Aug 29, 2021
@jbirnick
Copy link
Owner

jbirnick commented Oct 15, 2021

Since the newest update it's 3 lines you have to edit:

printExpiryTime () { :; }
printPaused () { :; }
removePrinting () { :; }

@CNote1
Copy link

CNote1 commented Dec 10, 2021

I've got syntax error after editing these lines.

@jbirnick
Copy link
Owner

Thanks, I've edited it. Now it should work.

@raffaem
Copy link

raffaem commented Jan 13, 2024

Why not use notify-send?

@jbirnick
Copy link
Owner

jbirnick commented Jan 13, 2024

Look at this screen recording:

expiryTimePreview

The notification is updated when you scroll. This is not possible with notify-send. With notify-send you could only spam new notifications, and then you suddenly have 50 notifications on your desktop.

EDIT: Oh wait, it seems like notify-send can do this nowadays?! Then I might replace this soon.

@jbirnick jbirnick added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Jan 13, 2024
@jbirnick jbirnick self-assigned this Jan 13, 2024
@jbirnick jbirnick reopened this Jan 13, 2024
@jbirnick
Copy link
Owner

Now it only uses notify-send.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants