Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimble lock computes different hash on Windows than Linux/macOS #81

Open
iffy opened this issue Feb 26, 2024 · 3 comments
Open

nimble lock computes different hash on Windows than Linux/macOS #81

iffy opened this issue Feb 26, 2024 · 3 comments

Comments

@iffy
Copy link

iffy commented Feb 26, 2024

I filed this issue with nimble: nim-lang/nimble#1188

I don't really know what the fix is. The trouble is that this repo's .gitattributes file causes a different hash to be computed on Windows vs Linux/macOS, but I can understand why you want that file in this repo. Do you have a suggestion?

@jangko
Copy link
Owner

jangko commented Feb 27, 2024

because of EOL conversion?

@iffy
Copy link
Author

iffy commented Feb 27, 2024

Yes, nimble computes a hash of the directory of installed packages for use in a lock file. On Windows, because of the EOL conversion, the hashes are different than those on Linux/macOS.

@jangko
Copy link
Owner

jangko commented Feb 28, 2024

actually only one file is problematic tests/basic.mp should be treated as binary instead of text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants