Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPDS: fb2 books are not available #3243

Open
Nik-mmzd opened this issue Nov 25, 2024 · 7 comments
Open

OPDS: fb2 books are not available #3243

Nik-mmzd opened this issue Nov 25, 2024 · 7 comments
Labels
bug Fixed in Nightly

Comments

@Nik-mmzd
Copy link

Nik-mmzd commented Nov 25, 2024 •
edited
Loading

After updating from 0.6.21-ls256 to 0.6.24-ls299 fb2 format is missing when accessing calibre-web using opds. FB2 is still available for manual download in calibre-web interface.

Calibre-web 0.6.24 (Docker, linuxserver 0.6.24-ls299)
Moon+ Reader 9.7 from GooglePlay

I suspect commit 09c0794 to be the cause (application/fb2+zip => text/xml).
@Nik-mmzd
Copy link
Author

I think the issue is that most readers rely on the fb2 or fictionbook keywords in the MIME type to identify FB2 files, as there is no officially standardized MIME type for FB2

@Raf2k
Copy link

Raf2k commented Dec 2, 2024

I faced the same issue. Unfortunately, if we change mime type back to application/fb2+zip or something else other than text/xml - we wont be able to upload fb2 files (there is mime verification and magic lib detects fb2 as text/xml). We can add special config for fb2 in /etc/magic (which is not very universal solution and I didn't find what exactly should be added) or we can switch from magic to other solution or we can have in and out mime types to override values in such cases. I haven't decided for myself yet, so I don't suggest any solution. Maybe @OzzieIsaacs has his own vision, idk... As far as I know fb2 is not too popular format...

@OzzieIsaacs
Copy link
Collaborator

I have a patch ready, I’ll test it and can publish it this week, hopefully

@Nik-mmzd
Copy link
Author

Nik-mmzd commented Dec 2, 2024

I contacted Moon+ Reader dev:

we'll modify the identify procedure (mark book that the url contains "/fb2/" as fb2 book directly)

I'll keep this issue open as the issue should be solved on Calibre-Web side, not work-arounded on all possible clients.

@Nik-mmzd
Copy link
Author

Nik-mmzd commented Dec 2, 2024

As far as I know fb2 is not too popular format...

In most places - maybe. In post-Soviet countries such as Russia, Ukraine and Belarus, this seems to be the most popular ebooks format.

@Raf2k
Copy link

Raf2k commented Dec 2, 2024

As far as I know fb2 is not too popular format...

In most places - maybe. In post-Soviet countries such as Russia, Ukraine and Belarus, this seems to be the most popular ebooks format.

Yeah. 99% of my library is in fb2.

OzzieIsaacs added a commit that referenced this issue Dec 7, 2024
@OzzieIsaacs
Added logging of ip address (#3237)
42924d9 
Refactored Response(json.dumps -> make_response(jsonify..)
Update mimetypes - Allow different mimetypes for download and file upload check (#3245, #3243)
Bugfixes from tests
Updated optional-requirements
OzzieIsaacs added a commit that referenced this issue Dec 7, 2024
@OzzieIsaacs
Added logging of ip address (#3237)
21989c3 
Refactored Response(json.dumps -> make_response(jsonify..)
Update mimetypes - Allow different mimetypes for download and file upload check (#3245, #3243)
Bugfixes from tests
Updated optional-requirements
@OzzieIsaacs
Copy link
Collaborator

Should be aavailable in the newest nightly build(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixed in Nightly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Raf2k @OzzieIsaacs @Nik-mmzd