Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Sort by Channel" to mixer view #3417

Closed
pljones opened this issue Oct 25, 2024 · 1 comment · Fixed by #3418
Closed

Add "Sort by Channel" to mixer view #3417

pljones opened this issue Oct 25, 2024 · 1 comment · Fixed by #3418
Assignees
Labels
feature request Feature request

Comments

@pljones
Copy link
Collaborator

pljones commented Oct 25, 2024

What is the current behaviour and why should it be changed?

Currently, when "No user sort" is specified, "faders are sorted in the order they appeared" -- and sometimes (quite rarely) this isn't the same as the channel number:
image

Because --ctrlmidich uses the channel numbers to assign Jamulus channels to MIDI controllers, it improves user experience to be able to sort the faders to match and this is not currently possible.

Describe possible approaches

The existing "No user sort" could be replaced with or have its meaning changed to "Sort by channel".

However, this might not be what all users want and invalidates the current definition, so I'm proposing that "Sort by channel" is a new option.

I'm also proposing to extend the "and then by name" to the other non-unique sorts: City and Group and ensure Group sorts properly numerically.

Plus refactoring what's clearly a switch from a bunch of if .. else if .. statements into a proper switch.

Has this feature been discussed and generally agreed?

This arises from the changes recently to --ctrlmidich - just something I thought of.

@pljones pljones added the feature request Feature request label Oct 25, 2024
@pljones pljones added this to Tracking Oct 25, 2024
@pljones pljones self-assigned this Oct 25, 2024
@github-project-automation github-project-automation bot moved this to Triage in Tracking Oct 25, 2024
@pljones pljones moved this from Triage to In Progress in Tracking Oct 25, 2024
@pljones pljones added this to the Release 3.12.0 milestone Oct 25, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Tracking Oct 29, 2024
@pljones
Copy link
Collaborator Author

pljones commented Oct 29, 2024

jamulussoftware/jamuluswebsite#1059 raised to get the documentation change done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant