Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: integrate with github deployment api #8

Open
KnisterPeter opened this issue Sep 15, 2019 · 1 comment
Open

Feature request: integrate with github deployment api #8

KnisterPeter opened this issue Sep 15, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@KnisterPeter
Copy link

It would be great to integrate with github deployment / deployment_status apis.
I'm not sure if netflify supports this, since I'm not using netlify, but it will work with zeit now.

I guess the right way would be to listen to deployment_status updates until the status is success. In the response of that we have the deployment URL which could then be used to run lighthouse on.
@jakejarvis
Copy link
Owner

Great idea — this would also solve the race condition problem (#2) I believe. Right now in my personal use I had to put sleep 30 as a step between deployment and Lighthouse to mitigate this. Will look into this as soon as I get a chance, thanks!

@jakejarvis jakejarvis added the enhancement New feature or request label Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KnisterPeter @jakejarvis