Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Different score to lighthouse on latest ubuntu chrome #25

Open
Lewiscowles1986 opened this issue Nov 12, 2020 · 1 comment · May be fixed by #26
Open

Bug: Different score to lighthouse on latest ubuntu chrome #25

Lewiscowles1986 opened this issue Nov 12, 2020 · 1 comment · May be fixed by #26

Comments

@Lewiscowles1986
Copy link

Firstly thanks for making this really cool thing.

When I ran this I was surprised to see no PWA score, and a different score to that I see in-browser.

At first I thought, it's likely just because I'm targetting the non-canonical URL for my site, so I duplicated a GitHub action to use the canonical URL. It's still the same score.

So I opened Chrome things change, maybe my score went down. Except it hasn't changed. I run it again for desktop instead of mobile and I do see 96 instead of 95, so closer to the output of this tool.

lighthouse-reports.zip
@Lewiscowles1986
Copy link
Author

Lewiscowles1986 commented Nov 12, 2020 •
edited
Loading

It looks like this is an issue with HTTPS I've got another zip with the live site results in. Funny thing is that even with HTTPS both github pages and my own site say they fail HTTPS but do not specify why. There is no mixed content I can find in browser.

lighthouse-reports.zip

Lewiscowles1986 added a commit to Lewiscowles1986/lighthouse-action that referenced this issue Nov 12, 2020
@Lewiscowles1986
Install recommendations in base image
296d6f5 
Fixes jakejarvis#25 when I run from my computer

```
docker run --name lighthouse-action --workdir /github/workspace --rm -e OUTPUT_PATH=/github/workspace -e INPUT_URL=https://www.lewiscowles.co.uk -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_WORKSPACE=/github/workspace -e GITHUB_ACTION -e GITHUB_EVENT_PATH=/dev/null -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v $(pwd):"/github/workspace" lighthouse-action
```

Obviously a lot I'm missing having just lifted this from the Github action namespace, and a little confused how `INPUT_URL` is mapped to `REPORT_URL` etc, but it worked to give me my 100 score 😁
@Lewiscowles1986 Lewiscowles1986 linked a pull request Nov 12, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install recommendations in base image Lewiscowles1986/lighthouse-action
1 participant
@Lewiscowles1986