Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: include web server #12

Open
georgeboot opened this issue Sep 27, 2019 · 3 comments
Open

Feature request: include web server #12

georgeboot opened this issue Sep 27, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@georgeboot
Copy link

georgeboot commented Sep 27, 2019

It would be super handy if this package could also include a super simple web server.

Currently, we're building a Vue app, but there is no way to have the dist/index.html audited, since there is no webserver.

We're currently using Netlify, but the action runs faster then Netlify can deploy, so it fails (when the action runs, Netlify has not yet finished deploying the preview, meaning a 404 response).

If the package could also have a path option, one could simply point to the directory of static html files and have this action start a simple webserver and audit against that.

@jakejarvis
Copy link
Owner

Hi there, apologies for the late reply!

This crossed my mind too and I'll look into the best way to do this — maybe a simple one-line Python server like python -m SimpleHTTPServer 8000 would suffice. As for the Netlify race condition, this is at the top of my to-do list (also discussed in #14) since this is likely a problem in 99% of use cases. I'll keep you posted, thanks for reaching out!

@jakejarvis jakejarvis added the enhancement New feature or request label Oct 13, 2019
@jakejarvis jakejarvis self-assigned this Oct 13, 2019
@pixelass
Copy link

We would also love to use this with a local server.

Use Case: next.js server

Steps:

  1. yarn build
  2. yarn start (never finishes since the server is running)
  3. run lighthouse action

Thanks in advance

@georgeboot
Copy link
Author

Perhaps this package could be of use?
https://github.com/marketplace/actions/http-server-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants