Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEXTURE TEMPLATE UPDATE] Convert meadows to fields #82

Closed
H4rdB4se opened this issue Dec 23, 2024 · 3 comments · Fixed by #83
Closed

[TEXTURE TEMPLATE UPDATE] Convert meadows to fields #82

H4rdB4se opened this issue Dec 23, 2024 · 3 comments · Fixed by #83
Assignees
@iwatkot
Labels
enhancement New feature or request

Comments

@H4rdB4se
Copy link

I noticed that some fields are missing in my area. Therefore I checked OSM and saw that they are labelled as meadow (landuse=meadow).
In my opinion it makes much sense to also convert meadows into fields. And it would be great to turn on "missionOnlyGrass"
image
for that fields, because those fields are mainly used for grass.

You can also add both points (meadow to field conversion & missionOnlyGrass option) to the "Advanced settings" if you don't want to enforce that for all users.

I would appreciate that enhancement.
Thank you for your great work on this project.
@github-actions GitHub Actions
Copy link

Thank you for opening an issue!
Please, first check the FAQ to see if your question has already been answered.
Note, that all issues regarding the availability of the StreamLit community app will be closed automatically. Please use the Docker version of the tool. Thank you!

If you want to proceed with the issue, please provide the following information:
- Coordinates of the cetral point of the map
- Map size
- Was auto preset enabled?
- Any additional settings if where enabled
- Error message if any
- Screenshots if possible
- Any additional information that you think might be useful

Thank you!

@iwatkot
Copy link
Owner

iwatkot commented Dec 23, 2024

@H4rdB4se, hey!

Thanks for the suggestion, I found it useful, and additional thanks for checking out OSM docs and providing a detailed explanation. I appreciate it.

  1. According to the OSM wiki, it sounds logical enough. I guess I'll add it after some tests.

  2. Regarding changing the value of a checkbox, I don't think I want to add it, because it will make the code more complex in the places, where in my opinion it should be simple and straightforward. But I'll think about it.

Regards

@iwatkot iwatkot self-assigned this Dec 23, 2024
@iwatkot iwatkot added the enhancement New feature or request label Dec 23, 2024
@iwatkot iwatkot changed the title Convert meadows to fields [TEXTURE TEMPLATE UPDATE] Convert meadows to fields Dec 23, 2024
@iwatkot iwatkot linked a pull request Dec 23, 2024 that will close this issue
Water planes generation, water depth option for DEM #83
Merged
@iwatkot
Copy link
Owner

iwatkot commented Dec 23, 2024

@H4rdB4se, the PR is linked to the issue.

It will be automatically closed once it's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwatkot iwatkot

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Water planes generation, water depth option for DEM iwatkot/maps4fs
2 participants
@H4rdB4se @iwatkot