Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing golf properties #196

Open
bquinn opened this issue Aug 12, 2024 · 1 comment · Fixed by #208
Open

Missing golf properties #196

bquinn opened this issue Aug 12, 2024 · 1 comment · Fixed by #208
Assignees

Comments

@bquinn
Copy link
Contributor

bquinn commented Aug 12, 2024

Looking at fixing #192, I noticed that some of the golf examples refer to properties that haven't been defined

<http://pga.com/Action/masters-2022_r4_33204_15_3>
        rdf:type                       sport:Action ;
        rdfs:label                     "Rory McIlroy Shot 3, Hole 15, Round 4 at Masters 2022" ;
        sport:actionDateTime           "2022-04-07T10:33:57-05:00"^^xsd:dateTime ;
        sport:actionInEvent            <http://pga.com/Event/masters-2022> ;
        sport:class                    spactionclass:play ;
        sport:actionType               spgolfactiontype:shot ;
        golf:shotType                  spgolshot:chip ;
        golf:round                     "4" ;
        golf:hole                      "15" ;
        golf:stroke                    "3" ;
        golf:zone                      "4" ;
        golf:shot-location             "700083.907,1274390.481,317.248" ;
        golf:shot-distance             "10171.500" ;
        golf:distance-remaining        "6230.200" ;
        sport:participation   <http://pga.com/Participation/masters-2022_r4_33204_15_3> .

The spgolfactiontype and golf CVs don’t exist. Do we need to create them?

(Note that we do have spgolshot and spgolstat, but nothing contains terms like “round”, “hole”, “shotType” etc.)

For “spgolfactiontype:shot” (which refers to a CV that doesn’t exist), should we be using something like spactionclass:play (which does exist!) instead?

@bquinn
Copy link
Contributor Author

bquinn commented Aug 20, 2024

We agreed today that this will be fixed in version 1.1 - by adding missing properties to the ontology.

bquinn added a commit that referenced this issue Sep 11, 2024
… handled by #196 (#198)

* Added RDF prefixes so files in /examples now validate - except for golf which is covered separately
* Adding very simple validator script
@bquinn bquinn linked a pull request Sep 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants