-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate player tenure info #164
Milestone
Comments
As described in iptc/sportsml-3#68, we can solve this by fixing the IDs generated in the SportsML conversion. |
pauljkelly
added a commit
that referenced
this issue
Sep 17, 2023
bquinn
added a commit
that referenced
this issue
Sep 20, 2023
…mittee vote (#170) * Turn "penalty-level" into "infractionLevel" and "penalty-type" into "infractionType" in XSLT for Actions. Fixes #162. * Feature/154 missing props in ontology (#169) * Added resultEffectTarget as per #154 * tweaks to samples to validate with SportsML xsd * Fixed XSLT issue that meant actions for esports (with no @id) were not being converted. Fixes #118. * Adding SportsML to comparison tables. Fixes #137. * Added personReplacingPosition to ontology. Fixes #173. * Removed scoreAttemptDescription and oppositePlay from ontology. Fixes #174. * Updated ontology docs to cover recent changes. * Added date to player memberships in roster info. Issue #164 * Fix some CV references to make them valid prefixes * Fixed esports ontology reference (no longer cv.iptc.org) * SHACL validation now works * spstat:resultEffect and spstat:resultEffectTarget should have domain of Participation * Adding Athlete entry and rdf:type even when we don't know the player's name (although this causes problems with some test queries which we still have to fix) * Introduce uniformNumberEvent which overrides uniformNumber for an individual event. * Fix newscodes prefix typo for ice hockey position in example * XSLT fix for one type of resultEffect that was generating a string instead of a URI * Added missing properties from ParticipationSplit and a fudge for resultEffectTarget. * Added version info to all ontology files. --------- Co-authored-by: pauljkelly <[email protected]>
pauljkelly
added a commit
that referenced
this issue
May 14, 2024
* Merge main into develop (#160) * Bringing in latest work from main into develop, both branches will be the same after this action * Re-generated merged ontology file * Turn "penalty-level" into "infractionLevel" and "penalty-type" into "infractionType" in XSLT for Actions. Fixes #162. * Feature/154 missing props in ontology (#169) * Added resultEffectTarget as per #154 * Update test output to match the ontology changes * - tweaks to samples to validate with SportsML xsd * - SportsML samples all valid - tests run almost clean with remaining schema issues flagging (personReplacing) * Fixed XSLT issue that meant actions for esports (with no @id) were not being converted. Fixes #118. * Adding SportsML to comparison tables. Fixes #137. * Added personReplacingPosition to ontology. Fixes #173. * Removed scoreAttemptDescription and oppositePlay from ontology. Fixes #174. * Updated ontology docs to cover recent changes. * - numerous issue fixes all documented in gihub * - added date to player memberships in roster info. Issue #164 * Fixed definition - fixes #173 * Whoops, introduced a formatting bug - now fixing * Fix some CV references to make them valid prefixes * Small change to ontology found during shacl validation * Fixing esports ontology reference * Lots of work on SHACL, now validates most examples (but not yet all) * Fixing prefix/URI for esports ontology, included in many files as a header * spstat:resultEffect and spstat:resultEffectTarget should have domain of Participation * Adding Athlete entry and rdf:type even when we don't know the player's name * Add missing properties, many more examples validate now * Introduce uniformNumberEvent which overrides uniformNumber for an individual event. * Fix newscodes prefix typo for ice hockey position in example * XSLT fix for one type of resultEffect that was generating a string instead of a URI * Added missing properties from ParticipationSplit and a fudge for resultEffectTarget. Now all sample files pass SHACL validation! * Update properties-used test output to match latest ontology change * Added version info to the ontology file. * Add versioning info to all sport-specific ontologies * - uniformNumberEvent to distinguish from Athlete property - removed awards (mapped to rank property) for the time being * Fixing N3 version of Oly Medals example * - trying again * Sport Schema v1.0.1: Fixing datatype of properties containing SKOS Concepts (#185) * Fixing datatype of properties containing SKOS Concepts, a bug in the original schema so doesn't need a vote. Updating version number to 1.0.1 throughout and updating dates. * Changed range from sport:event to sport:Event. Fixes #180. * Changing created/modified dates as per our new policy. Fixes #186. * Updating HTML docs in line with recent changes to created/modified dates. --------- Co-authored-by: Brendan Quinn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I looked at the SportsML for career phases and it's inadequate for this model (see SportsML ticket iptc/sportsml-3#68). Need to review what we're getting from the SportsML samples and determine if it's good.
The text was updated successfully, but these errors were encountered: